docs(plans): credential-pool failover + approval-coalescing plans#42
Merged
nnemirovsky merged 1 commit intoMay 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two implementation plans, both auto-reviewed by the plan-review agent and revised to address all critical/important findings.
20260515-credential-pool-failover.mdOne phantom identity backed by N OAuth credentials (a pool), auto-failover to the next member on 429/401. Driving case: two OpenAI Codex accounts behind one agent.
Review-driven fixes baked in:
resignJWTis per-real-token, which would otherwise break the "agent never notices" property).binding.Credential/OAuthIndex.Hasconsumer.20260515-approval-coalescing.mdCoalesce duplicate Telegram approval prompts by
dest:port(the persisted-rule granularity), so a burst of requests to one target produces one prompt, not the reported wall of identical prompts.Review-driven fixes baked in:
broker.Requestsites; SSH/IMAP/SMTP share the HTTP site (coalesce uniformly); MCP is the one that opts out (arg-sensitive). The original SSH opt-out was based on a non-existent site.Store.HasApprovalRuleSELECT for idempotent persist (no migration).Resolvesnapshots subs under lock.Both are phased with per-task test gates. Plans only — no code changes.