Change downloadURL to parser property, force Version comparison usage

Author: noah978

src/altparse/core.py

@@ -164,26 +164,29 @@ def update(self, **kwargs):
                         app = self.src.apps[existingAppIDs.index(id)]
 
                         # try to use absoluteVersion if the App contains it
-                        if version.parse(app.versions[0].absoluteVersion if app.versions[0].absoluteVersion else app.versions[0].version) < version.parse(parser.version) or (parser.prefer_date and parse_github_datetime(app.versions[0].date) < parse_github_datetime(parser.versionDate)): 
+                        new_ver = {
+                            "absoluteVersion": parser.version,
+                            "version": parser.version,
+                            "date": parser.versionDate,
+                            "size": 0,
+                            "downloadURL": parser.downloadURL
+                        }
+                        
+                        new_ver = AltSource.App.Version(new_ver)
+                        
+                        if app.latest_version() < new_ver or (parser.prefer_date and parse_github_datetime(app.latest_version(True).date) < parse_github_datetime(new_ver.date)): 
                             metadata = parser.get_asset_metadata()
 
-                            new_ver = {
-                                "absoluteVersion": parser.version,
-                                "date": parser.versionDate,
-                                "localizedDescription": parser.versionDescription,
-                                "size": metadata.get("size"),
-                                "sha256": metadata.get("sha256"),
-                                "version": metadata.get("version") or parser.version,
-                                "buildVersion": metadata.get("buildVersion"),
-                                "downloadURL": metadata.get("downloadURL")
-                            }
-                            
-                            new_ver = AltSource.App.Version(new_ver)
+                            new_ver.version = metadata.get("version") or parser.version
+                            new_ver.buildVersion = metadata.get("buildVersion")
+                            new_ver.size = metadata.get("size")
+                            new_ver.sha256 = metadata.get("sha256")
+                            new_ver.localizedDescription = parser.versionDescription
 
                             if not metadata.get("bundleIdentifier"):
                                 logging.error("No bundleIdentifier found in IPA.")
                             elif metadata["bundleIdentifier"] != app.bundleIdentifier:
-                                logging.warning(app.name + " BundleID has changed to " + metadata["bundleIdentifier"])
+                                logging.warning(app.name + " BundleID changed. This may cause issues with automatic updates.")
                                 app.bundleIdentifier = metadata["bundleIdentifier"]
                                 new_ver.localizedDescription += "\n\nNOTE: BundleIdentifier changed in this version and automatic updates have been disabled until manual install occurs."
 

src/altparse/parsers.py

@@ -140,6 +140,10 @@ def __init__(self, url: str = "https://unc0ver.dev/releases.json", ver_parse: Ca
         else:
             self.data = sorted(releases, key=lambda x: version.parse(x["tag_name"]))[-1] # only grab the release with the highest version
 
+    @property
+    def downloadURL(self) -> str:
+        return "https://unc0ver.dev" + self.data["browser_download_url"]
+
     @property
     def version(self) -> str:
         return self.data["tag_name"]
@@ -155,11 +159,9 @@ def versionDescription(self) -> str:
     def get_asset_metadata(self) -> dict[str]:
         """Returns a dictionary containing the downloadURL, size, bundleID, version
         """
-        download_url = "https://unc0ver.dev" + self.data["browser_download_url"]
-        ipa_path = download_tempfile(download_url)
+        ipa_path = download_tempfile(self.downloadURL)
         if ipa_path is not None:
             metadata = extract_altstore_metadata(ipa_path)
-        metadata["downloadURL"] = download_url
         return metadata
 
 class GithubParser:
@@ -244,6 +246,13 @@ def alter_tag_names(releases: list):
             alter_tag_names(releases)
             self.data = sorted(releases, key=lambda x: version.parse(x["tag_name"]))[-1] # only grab the release with the highest version
 
+    @property
+    def downloadURL(self) -> str:
+        return self.data["asset"]["browser_download_url"]
+    @downloadURL.setter
+    def downloadURL(self, value: str):
+        self.data["asset"]["browser_download_url"] = value
+
     @property
     def version(self) -> str:
         return self.data["tag_name"]
@@ -262,9 +271,7 @@ def get_asset_metadata(self) -> dict[str]:
         Returns:
             dict: A dictionary containing the downloadURL, size, bundleID, version, and more.
         """
-        download_url = self.data["asset"]["browser_download_url"]
-
-        ipa_path = download_tempfile(download_url)
+        ipa_path = download_tempfile(self.downloadURL)
         if ipa_path is not None:
             payload_path = extract_ipa(ipa_path, self.extract_twice)
             if self.extract_twice:
@@ -274,9 +281,8 @@ def get_asset_metadata(self) -> dict[str]:
 
             # Uploads the ipa to a separate GitHub repository after its been processed
             if self.upload_ipa_repo is not None:
-                download_url = upload_ipa_github(ipa_path, self.upload_ipa_repo, name=metadata["bundleIdentifier"], ver=metadata["version"])
-        
-        metadata["downloadURL"] = download_url
+                self.downloadURL = upload_ipa_github(ipa_path, self.upload_ipa_repo, name=metadata["bundleIdentifier"], ver=metadata["version"])
+
         return metadata
 
 class Parser(Enum):