Skip to content

Commit 1119bb0

Browse files
committed
[Feature #21205] Fix up birthtime in rubyspec
1 parent 32ba9d4 commit 1119bb0

2 files changed

Lines changed: 34 additions & 47 deletions

File tree

Lines changed: 20 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,20 @@
11
require_relative '../../spec_helper'
22

3-
describe "File.birthtime" do
4-
before :each do
5-
@file = __FILE__
6-
end
3+
supported = [:windows, :darwin, :freebsd, :netbsd]
4+
ruby_version_is "3.5" do
5+
supported << :linux
6+
end
77

8-
after :each do
9-
@file = nil
10-
end
8+
platform_is *supported do
9+
describe "File.birthtime" do
10+
before :each do
11+
@file = __FILE__
12+
end
13+
14+
after :each do
15+
@file = nil
16+
end
1117

12-
platform_is :windows, :darwin, :freebsd, :netbsd do
1318
it "returns the birth time for the named file as a Time object" do
1419
File.birthtime(@file)
1520
File.birthtime(@file).should be_kind_of(Time)
@@ -24,37 +29,21 @@
2429
end
2530
end
2631

27-
platform_is :openbsd do
28-
it "raises an NotImplementedError" do
29-
-> { File.birthtime(@file) }.should raise_error(NotImplementedError)
32+
describe "File#birthtime" do
33+
before :each do
34+
@file = File.open(__FILE__)
3035
end
31-
end
3236

33-
# TODO: depends on Linux kernel version
34-
end
35-
36-
describe "File#birthtime" do
37-
before :each do
38-
@file = File.open(__FILE__)
39-
end
40-
41-
after :each do
42-
@file.close
43-
@file = nil
44-
end
37+
after :each do
38+
@file.close
39+
@file = nil
40+
end
4541

46-
platform_is :windows, :darwin, :freebsd, :netbsd do
4742
it "returns the birth time for self" do
4843
@file.birthtime
4944
@file.birthtime.should be_kind_of(Time)
5045
end
5146
end
5247

53-
platform_is :openbsd do
54-
it "raises an NotImplementedError" do
55-
-> { @file.birthtime }.should raise_error(NotImplementedError)
56-
end
57-
end
58-
5948
# TODO: depends on Linux kernel version
6049
end
Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,25 @@
11
require_relative '../../../spec_helper'
22

3-
describe "File::Stat#birthtime" do
4-
before :each do
5-
@file = tmp('i_exist')
6-
touch(@file) { |f| f.write "rubinius" }
7-
end
3+
supported = [:windows, :darwin, :freebsd, :netbsd]
4+
ruby_version_is("3.5") do
5+
supported << :linux
6+
end
87

9-
after :each do
10-
rm_r @file
11-
end
8+
platform_is *supported do
9+
describe "File::Stat#birthtime" do
10+
before :each do
11+
@file = tmp('i_exist')
12+
touch(@file) { |f| f.write "rubinius" }
13+
end
14+
15+
after :each do
16+
rm_r @file
17+
end
1218

13-
platform_is :windows, :darwin, :freebsd, :netbsd do
1419
it "returns the birthtime of a File::Stat object" do
1520
st = File.stat(@file)
1621
st.birthtime.should be_kind_of(Time)
1722
st.birthtime.should <= Time.now
1823
end
1924
end
20-
21-
platform_is :linux, :openbsd do
22-
it "raises an NotImplementedError" do
23-
st = File.stat(@file)
24-
-> { st.birthtime }.should raise_error(NotImplementedError)
25-
end
26-
end
2725
end

0 commit comments

Comments
 (0)