Skip to content

Commit 620ecfb

Browse files
committed
[Bug #21629] Deprecate rb_setup_fake_str
1 parent 67be30d commit 620ecfb

3 files changed

Lines changed: 3 additions & 13 deletions

File tree

ext/-test-/string/fstring.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,6 @@ bug_s_fstring(VALUE self, VALUE str)
88
return rb_str_to_interned_str(str);
99
}
1010

11-
VALUE
12-
bug_s_fstring_fake_str(VALUE self)
13-
{
14-
static const char literal[] = "abcdefghijklmnopqrstuvwxyz";
15-
struct RString fake_str;
16-
return rb_str_to_interned_str(rb_setup_fake_str(&fake_str, literal, sizeof(literal) - 1, 0));
17-
}
18-
1911
VALUE
2012
bug_s_rb_enc_interned_str(VALUE self, VALUE encoding)
2113
{
@@ -32,7 +24,6 @@ void
3224
Init_string_fstring(VALUE klass)
3325
{
3426
rb_define_singleton_method(klass, "fstring", bug_s_fstring, 1);
35-
rb_define_singleton_method(klass, "fstring_fake_str", bug_s_fstring_fake_str, 0);
3627
rb_define_singleton_method(klass, "rb_enc_interned_str", bug_s_rb_enc_interned_str, 1);
3728
rb_define_singleton_method(klass, "rb_enc_str_new", bug_s_rb_enc_str_new, 1);
3829
}

internal/string.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ RUBY_SYMBOL_EXPORT_BEGIN
8080
/* string.c (export) */
8181
VALUE rb_str_tmp_frozen_acquire(VALUE str);
8282
void rb_str_tmp_frozen_release(VALUE str, VALUE tmp);
83+
#ifdef RBIMPL_ATTR_DEPRECATED_INTERNAL
84+
RBIMPL_ATTR_DEPRECATED_INTERNAL(3.5)
85+
#endif
8386
VALUE rb_setup_fake_str(struct RString *fake_str, const char *name, long len, rb_encoding *enc);
8487
RUBY_SYMBOL_EXPORT_END
8588

test/-ext-/string/test_fstring.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ def test_singleton_class
5757
assert_raise(TypeError) {fstr.singleton_class}
5858
end
5959

60-
def test_fake_str
61-
assert_equal([*"a".."z"].join(""), Bug::String.fstring_fake_str)
62-
end
63-
6460
class S < String
6561
end
6662

0 commit comments

Comments
 (0)