Skip to content

Commit b6afc8b

Browse files
jeremyevansmatzbot
authored andcommitted
[ruby/rubygems] Change Gem::Version#approximate_recommendation to be optimistic
Previously, this used a pessimistic recommendation. This switches it to give an optimistic recommendation. ruby/rubygems@de24c15410
1 parent b28949c commit b6afc8b

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

lib/rubygems/version.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ def segments # :nodoc:
325325
end
326326

327327
##
328-
# A recommended version for use with a ~> Requirement.
328+
# A recommended version for use with a >= Requirement.
329329

330330
def approximate_recommendation
331331
segments = self.segments
@@ -334,7 +334,7 @@ def approximate_recommendation
334334
segments.pop while segments.size > 2
335335
segments.push 0 while segments.size < 2
336336

337-
recommendation = "~> #{segments.join(".")}"
337+
recommendation = ">= #{segments.join(".")}"
338338
recommendation += ".a" if prerelease?
339339
recommendation
340340
end

test/rubygems/test_gem_version.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,25 +165,25 @@ def test_spaceship
165165
end
166166

167167
def test_approximate_recommendation
168-
assert_approximate_equal "~> 1.0", "1"
168+
assert_approximate_equal ">= 1.0", "1"
169169
assert_approximate_satisfies_itself "1"
170170

171-
assert_approximate_equal "~> 1.0", "1.0"
171+
assert_approximate_equal ">= 1.0", "1.0"
172172
assert_approximate_satisfies_itself "1.0"
173173

174-
assert_approximate_equal "~> 1.2", "1.2"
174+
assert_approximate_equal ">= 1.2", "1.2"
175175
assert_approximate_satisfies_itself "1.2"
176176

177-
assert_approximate_equal "~> 1.2", "1.2.0"
177+
assert_approximate_equal ">= 1.2", "1.2.0"
178178
assert_approximate_satisfies_itself "1.2.0"
179179

180-
assert_approximate_equal "~> 1.2", "1.2.3"
180+
assert_approximate_equal ">= 1.2", "1.2.3"
181181
assert_approximate_satisfies_itself "1.2.3"
182182

183-
assert_approximate_equal "~> 1.2.a", "1.2.3.a.4"
183+
assert_approximate_equal ">= 1.2.a", "1.2.3.a.4"
184184
assert_approximate_satisfies_itself "1.2.3.a.4"
185185

186-
assert_approximate_equal "~> 1.9.a", "1.9.0.dev"
186+
assert_approximate_equal ">= 1.9.a", "1.9.0.dev"
187187
assert_approximate_satisfies_itself "1.9.0.dev"
188188
end
189189

0 commit comments

Comments
 (0)