Skip to content

Commit c336168

Browse files
committed
Revert "Gererate prism source files dependencies from template.rb"
This reverts commit d0d7f55.
1 parent fae0fb6 commit c336168

9 files changed

Lines changed: 16 additions & 209 deletions

File tree

common.mk

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,13 @@ $(PRISM_BUILD_DIR)/.time $(PRISM_BUILD_DIR)/util/.time:
205205
$(Q) $(MAKEDIRS) $(@D)
206206
@$(NULLCMD) > $@
207207

208+
$(PRISM_SRCDIR)/srcs.mk: $(HAVE_BASERUBY:yes=$(PRISM_SRCDIR)/templates/template.rb) \
209+
$(HAVE_BASERUBY:yes=$(PRISM_SRCDIR)/generate-srcs.mk.rb)
210+
$(ECHO) Updating prism/srcs.mk
211+
$(BASERUBY) $(PRISM_SRCDIR)/generate-srcs.mk.rb > $@
212+
213+
srcs: $(PRISM_SRCDIR)/srcs.mk
214+
208215
EXPORTOBJS = $(DLNOBJ) \
209216
localeinit.$(OBJEXT) \
210217
loadpath.$(OBJEXT) \
@@ -1214,6 +1221,7 @@ incs: $(INSNS) {$(VPATH)}node_name.inc {$(VPATH)}known_errors.inc \
12141221
{$(VPATH)}vm_call_iseq_optimized.inc $(srcdir)/revision.h \
12151222
$(REVISION_H) \
12161223
$(UNICODE_DATA_HEADERS) $(ENC_HEADERS) \
1224+
$(top_srcdir)/prism/ast.h $(top_srcdir)/prism/diagnostic.h \
12171225
{$(VPATH)}id.h {$(VPATH)}probes.dmyh
12181226

12191227
insns: $(INSNS)
@@ -1302,11 +1310,6 @@ $(REVISION_H)$(yes_baseruby:yes=~disabled~):
13021310
# uncommon.mk: $(REVISION_H)
13031311
# $(MKFILES): $(REVISION_H)
13041312

1305-
# $(common_mk_includes) is set by config.status or GNUmakefile
1306-
common_mk__$(gnumake:yes=artifact)_ = uncommon.mk
1307-
common_mk_$(gnumake)_artifact_ = $(MKFILES)
1308-
$(common_mk__artifact_): $(srcdir)/common.mk $(common_mk_includes)
1309-
13101313
ripper_srcs: $(RIPPER_SRCS)
13111314

13121315
$(RIPPER_SRCS): $(srcdir)/parse.y $(srcdir)/defs/id.def
@@ -1979,4 +1982,3 @@ $(CROSS_COMPILING:yes=)builtin.$(OBJEXT): {$(VPATH)}mini_builtin.c
19791982
$(CROSS_COMPILING:yes=)builtin.$(OBJEXT): {$(VPATH)}miniprelude.c
19801983

19811984
!include $(srcdir)/prism/srcs.mk
1982-
!include $(srcdir)/depend

configure.ac

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4683,12 +4683,9 @@ AC_CONFIG_FILES(Makefile:template/Makefile.in, [
46834683
sed '/^MISSING/s/\$U\././g;/^VCS *=/s#@VCS@#'"$VCS"'#;/^VCSUP *=/s#@VCSUP@#'"$VCSUP"'#' Makefile
46844684
echo; test x"$EXEEXT" = x || echo 'miniruby: miniruby$(EXEEXT)'
46854685
AS_IF([test "$gnumake" != yes], [
4686-
# extract NMake-style include list
4687-
set = `sed -n 's/^!include *//p' ${srcdir}/common.mk`
4688-
echo common_mk_includes "@S|@*" # generate the macro assignment
4689-
shift
4690-
common_mk_includes="`echo \"@S|@*\" | sed 's|\$(srcdir)|.|g'`"
4691-
(cd ${srcdir} && sed -f tool/prereq.status common.mk ${common_mk_includes})
4686+
echo ['$(MKFILES): $(srcdir)/common.mk $(srcdir)/depend $(srcdir)/prism/srcs.mk']
4687+
sed ['s/{\$([^(){}]*)[^{}]*}//g;/^!/d'] ${srcdir}/common.mk ${srcdir}/depend
4688+
cat ${srcdir}/prism/srcs.mk
46924689
AS_IF([test "$YJIT_SUPPORT" = yes], [
46934690
cat ${srcdir}/yjit/not_gmake.mk
46944691
echo ['$(MKFILES): ${srcdir}/yjit/not_gmake.mk']
@@ -4711,7 +4708,6 @@ AC_CONFIG_FILES(Makefile:template/Makefile.in, [
47114708
]) &&
47124709
test -z "`${MAKE-make} -f $tmpgmk info-program | grep '^PROGRAM=ruby$'`" &&
47134710
echo 'ruby: $(PROGRAM);' >> $tmpmk
4714-
rm -f uncommon.mk # remove stale uncommon.mk, it should be updated by GNUmakefile
47154711
test "$tmpmk" = "$tmpgmk" || rm -f "$tmpgmk"
47164712
]) && mv -f $tmpmk Makefile],
47174713
[EXEEXT='$EXEEXT' MAKE='${MAKE-make}' gnumake='$gnumake' GIT='$GIT' YJIT_SUPPORT='$YJIT_SUPPORT'])

prism/srcs.mk

Lines changed: 0 additions & 142 deletions
This file was deleted.

prism/srcs.mk.in

Lines changed: 0 additions & 40 deletions
This file was deleted.

template/GNUmakefile.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,5 @@ override UNICODE_TABLES_DEPENDENTS = \
2727
$(UNICODE_TABLES_DATA_FILES)))),\
2828
force,none)
2929

30-
# extract NMake-style include list
31-
$(eval common_mk_includes := $(shell sed -n 's/^!include *//p' $(srcdir)/common.mk))
32-
3330
-include uncommon.mk
3431
include $(srcdir)/defs/gmake.mk

template/Makefile.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,8 +426,8 @@ $(MKFILES): config.status $(srcdir)/version.h $(ABI_VERSION_HDR)
426426
$(MAKE) -f conftest.mk | grep '^AUTO_REMAKE$$' >/dev/null 2>&1 || \
427427
{ echo "$@ updated, restart."; exit 1; }
428428

429-
uncommon.mk: $(srcdir)/tool/prereq.status
430-
sed -f $(srcdir)/tool/prereq.status $(srcdir)/common.mk $(common_mk_includes) > $@
429+
uncommon.mk: $(srcdir)/common.mk $(srcdir)/depend
430+
sed -f $(srcdir)/tool/prereq.status $(srcdir)/common.mk $(srcdir)/depend > $@
431431

432432
.PHONY: reconfig
433433
reconfig-args = $(srcdir)/$(CONFIGURE) $(yes_silence:yes=--silent) $(configure_args)

tool/make-snapshot

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -480,14 +480,7 @@ def package(vcs, rev, destdir, tmp = nil)
480480
vars["UNICODE_VERSION"] = $unicode_version if $unicode_version
481481
args = vars.dup
482482
mk.gsub!(/@([A-Za-z_]\w*)@/) {args.delete($1); vars[$1] || ENV[$1]}
483-
commonmk.gsub!(/^!(?:include \$\(srcdir\)\/(.*))?/) do
484-
if inc = $1 and File.exist?(inc)
485-
File.binread(inc).gsub(/^!/, '# !')
486-
else
487-
"#"
488-
end
489-
end
490-
mk << commonmk.gsub(/\{\$([^(){}]*)[^{}]*\}/, "").sub(/^revision\.tmp::$/, '\& Makefile')
483+
mk << commonmk.gsub(/\{\$([^(){}]*)[^{}]*\}/, "").gsub(/^!/, '-').sub(/^revision\.tmp::$/, '\& Makefile')
491484
mk << <<-'APPEND'
492485
493486
update-download:: touch-unicode-files

tool/prereq.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ s,@srcdir@,.,g
4242

4343
s/@[A-Za-z][A-Za-z0-9_]*@//g
4444
s/{\$([^(){}]*)}//g
45-
s/^!/#!/
45+
s/^!/-/

win32/Makefile.sub

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -569,6 +569,7 @@ ACTIONS_ENDGROUP = @::
569569
ABI_VERSION_HDR = $(hdrdir)/ruby/internal/abi.h
570570

571571
!include $(srcdir)/common.mk
572+
!include $(srcdir)/depend
572573

573574
!ifdef SCRIPTPROGRAMS
574575
!else if [echo>scriptbin.mk SCRIPTPROGRAMS = \]

0 commit comments

Comments
 (0)