Skip to content

Commit c8233db

Browse files
authored
Ignore net-imap failures on Windows (ruby#14216)
1 parent cb28165 commit c8233db

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

tool/test-bundled-gems.rb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,15 @@
88

99
github_actions = ENV["GITHUB_ACTIONS"] == "true"
1010

11+
DEFAULT_ALLOWED_FAILURES = RUBY_PLATFORM =~ /mswin|mingw/ ? [
12+
'rbs',
13+
'debug',
14+
'irb',
15+
'power_assert',
16+
'net-imap',
17+
] : []
1118
allowed_failures = ENV['TEST_BUNDLED_GEMS_ALLOW_FAILURES'] || ''
12-
if RUBY_PLATFORM =~ /mswin|mingw/
13-
allowed_failures = [allowed_failures, "rbs,debug,irb,power_assert"].join(',')
14-
end
15-
allowed_failures = allowed_failures.split(',').uniq.reject(&:empty?)
19+
allowed_failures = allowed_failures.split(',').concat(DEFAULT_ALLOWED_FAILURES).uniq.reject(&:empty?)
1620

1721
# make test-bundled-gems BUNDLED_GEMS=gem1,gem2,gem3
1822
bundled_gems = ARGV.first || ''
@@ -113,7 +117,7 @@
113117
"with exit code #{$?.exitstatus}")
114118
puts colorize.decorate(mesg, "fail")
115119
if allowed_failures.include?(gem)
116-
mesg = "Ignoring test failures for #{gem} due to \$TEST_BUNDLED_GEMS_ALLOW_FAILURES"
120+
mesg = "Ignoring test failures for #{gem} due to \$TEST_BUNDLED_GEMS_ALLOW_FAILURES or DEFAULT_ALLOWED_FAILURES"
117121
puts colorize.decorate(mesg, "skip")
118122
else
119123
failed << gem

0 commit comments

Comments
 (0)