feat(translator): add configurable DeepLX-like backend#729
Draft
RanderDouble wants to merge 3 commits into
Draft
feat(translator): add configurable DeepLX-like backend#729RanderDouble wants to merge 3 commits into
RanderDouble wants to merge 3 commits into
Conversation
Contributor
|
@Cleboost - this PR modifies your plugin. Please review when you have a chance. |
Contributor
Automatic Code Quality ReviewFile: translator/LauncherProvider.qml
+ return fallback || (pluginApi?.tr("messages.connectionError") || "Connection error");
+ callback(null, pluginApi?.tr("messages.error") || "Translation error");
+ callback(null, pluginApi?.tr("messages.error") || "Translation error");File: translator/Settings.qml
+ label: "API URL"
+ label: pluginApi?.tr("settings.apiKey-label") || "API Key" |
Contributor
Automatic Code Quality ReviewFile: translator/LauncherProvider.qml
+ callback(null, pluginApi?.tr("messages.invalidApiKey") || "Invalid API Key"); |
Author
|
Addressed the i18n review feedback. Changes in this update:
|
spiros132
reviewed
Apr 23, 2026
Collaborator
spiros132
left a comment
There was a problem hiding this comment.
One minor feedback otherwise it lgtm :)
|
|
||
| function getErrorMessage(status, fallback) { | ||
| return fallback || pluginApi?.tr("messages.connectionError"); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'm a bit confused why this is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a minimal
DeepLX-like APIbackend option to the Translator plugin.Changes
DeepLX-like APIbackend in plugin settingsAPI URLand optionalAPI KeyfieldsPOSTJSONAuthorization: Bearer <token>when an API key is provideddataortranslations[0].textfrom the responseafter switching backends
Motivation
The current Google backend relies on an unofficial endpoint and may fail due to
rate limiting or anti-abuse checks.
This change adds support for self-hosted DeepLX-like endpoints while keeping the
implementation small and preserving the existing Google and DeepL backends.
Notes
googleanddeeplbackends are unchangedin the configured API URL