feat(wallcards): add smooth animated transitions between static and video wallpapers#812
feat(wallcards): add smooth animated transitions between static and video wallpapers#812sc0dyx wants to merge 2 commits into
Conversation
mpvpaperRun and wallpaperCommand now accepts 'duration' (ms) and uses 'sleep ms/1000' wallpaperCommand passes duration to mpvpaperRun for video entries
… duration Read global transitionDuration from Settings.data.wallpaper.transitionDuration For video: set thumbnail via WallpaperService (animated), then delay mpvpaper For static: explicitly kill mpvpaper to avoid background residue Pass duration to Utils.wallpaperCommand
|
@tonigineer - this PR modifies your plugin. Please review when you have a chance. |
| var wallpaperPath = f.isVideo ? f.thumbnail : f.filePath; | ||
| WallpaperService.changeWallpaper(wallpaperPath); | ||
|
|
||
| if (f.isVideo) { |
There was a problem hiding this comment.
Utils.wallpaperCommand already differentiates between video and image. The if/else is therefore not needed here.
|
I don't see that much of a difference on my system, but I am fine with adding it. Nevertheless, the transition between videos is still not great. I will keep it in mind and take care of it later. |
|
ok, thank you |
|
@tonigineer do you feel like this is ready to get merged in or should @sc0dyx change something in the PR? |
|
Hola @spiros132, I already commented, that I think, there is something that is unnecessary. But if you want to close the PR, merge it. I would take care of it in a next PR with a change from my side. Best regards, |
|
@sc0dyx do you want to add the suggested changes or should I merge this in? |
"ok, add the changes" |
|
@sc0dyx can you also bump the version number? |
|
If @sc0dyx is touching that PR again, he could also have a look at my remark ;) |
3 participants
Previously, switching video wallpapers caused an abrupt cut because mpvpaper was started immediately, ignoring Noctalia's built‑in wallpaper animation.
Now video wallpapers transition smoothly:
First, the video's first frame (thumbnail) is set as wallpaper, triggering the system animation (fade/wipe/etc.).
After waiting exactly
Settings.data.wallpaper.transitionDuration, mpvpaper starts with the live video.