Skip to content

added wallpaper carousel plugin#813

Draft
motor-dev wants to merge 2 commits into
noctalia-dev:mainfrom
motor-dev:main
Draft

added wallpaper carousel plugin#813
motor-dev wants to merge 2 commits into
noctalia-dev:mainfrom
motor-dev:main

Conversation

@motor-dev
Copy link
Copy Markdown

browse and pick wallpapers from a fullscreen carousel overlay

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Automatic Manifest Check


File: wallpaper-carousel/manifest.json

+  "repository": "https://github.com/TryCatch2022/wallpaperCarousel",

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Automatic Code Quality Review


File: wallpaper-carousel/Carousel.qml

  • (H) Line 575: Do not use hardcoded values, always prefer to use the Style singleton instead
+            spacing: 12
  • (H) Line 580: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Directory not found"
  • (H) Line 585: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "The configured directory '" + (root.cfg.wallpaperDirectory ?? "") + "' does not exist.\nCheck the path in Wallpaper Carousel settings."
  • (H) Line 590: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Press Escape to close"
  • (H) Line 598: Do not use hardcoded values, always prefer to use the Style singleton instead
+            spacing: 12
  • (H) Line 615: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Press Escape to close"

File: wallpaper-carousel/Settings.qml

  • (H) Line 8: Do not use hardcoded values, always prefer to use the Style singleton instead
+    spacing: 12
  • (H) Line 33: Do not use hardcoded values, always prefer to use the Style singleton instead
+        spacing: 2
  • (H) Line 65: Do not use hardcoded values, always prefer to use the Style singleton instead
+        spacing: 2
  • (H) Line 88: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "General"; font.bold: true; font.pixelSize: 14 }
  • (H) Line 90: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Wallpaper Directory"; font.bold: true }
  • (H) Line 98: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        text: "Override the wallpaper directory. Leave empty to follow the current wallpaper's directory."
  • (H) Line 103: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Carousel Mode"
  • (H) Line 104: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Standard stops at the edges. Wrap loops the index. Infinite shows a seamless repeating view."
  • (H) Line 107: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Standard", value: "standard" },
  • (H) Line 108: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Wrap",     value: "wrap"     },
  • (H) Line 109: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Infinite", value: "infinite" }
  • (H) Line 114: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Visual"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 117: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Background Dimming"; description: "Opacity of the dark overlay behind the carousel."
  • (H) Line 122: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Border Width"; description: "Width of the skewed border around thumbnails."
  • (H) Line 127: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Corner Radius"; description: "Corner radius of thumbnails. Set to 0 to disable."
  • (H) Line 132: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Size"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 135: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Width"; description: "Width of each wallpaper thumbnail."
  • (H) Line 140: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Height"; description: "Height of each wallpaper thumbnail."
  • (H) Line 145: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Center Tile Zoom"; description: "Size of the centered tile relative to the surrounding tiles."
  • (H) Line 150: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Expansion"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 153: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expand Selected"
  • (H) Line 154: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Expand the centered tile's width to reveal more of the image."
  • (H) Line 157: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Disabled", value: "false" },
  • (H) Line 158: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Enabled",  value: "true"  }
  • (H) Line 163: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expansion Amount"; description: "Width multiplier applied when the centered tile is expanded."
  • (H) Line 168: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold to Expand"
  • (H) Line 169: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Dwell on a tile to trigger a large immersive preview."
  • (H) Line 172: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Disabled", value: "false" },
  • (H) Line 173: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Enabled",  value: "true"  }
  • (H) Line 178: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Coverage"; description: "Screen coverage for the hold preview."
  • (H) Line 183: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Delay"; description: "Time to dwell on a tile before the preview activates."

File: wallpaper-carousel/WallpaperCarouselSettings.qml

  • (H) Line 70: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Wallpaper Directory"
  • (H) Line 71: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Override the wallpaper directory. Leave empty to follow system wallpaper."
  • (H) Line 78: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Carousel Mode"
  • (H) Line 79: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Standard stops at the edges. Wrap loops the index. Infinite shows a seamless repeating view."
  • (H) Line 82: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Standard", value: "standard" },
  • (H) Line 83: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Wrap", value: "wrap" },
  • (H) Line 84: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Infinite", value: "infinite" }
  • (H) Line 92: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Background Dimming"
  • (H) Line 100: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Border Width"
  • (H) Line 107: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Corner Radius"
  • (H) Line 118: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Width"
  • (H) Line 125: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Height"
  • (H) Line 132: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Center Tile Zoom"
  • (H) Line 143: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expand Selected"
  • (H) Line 144: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Expand the centered tile's width to reveal more of the image."
  • (H) Line 147: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Disabled", value: "false" },
  • (H) Line 148: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Enabled", value: "true" }
  • (H) Line 153: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expansion Amount"
  • (H) Line 161: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold to Expand"
  • (H) Line 162: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Dwell on a tile to trigger a large immersive preview."
  • (H) Line 165: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Disabled", value: "false" },
  • (H) Line 166: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Enabled", value: "true" }
  • (H) Line 171: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Coverage"
  • (H) Line 178: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Delay"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Automatic Code Quality Review


File: wallpaper-carousel/Carousel.qml

  • (H) Line 575: Do not use hardcoded values, always prefer to use the Style singleton instead
+            spacing: 12
  • (H) Line 580: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Directory not found"
  • (H) Line 585: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "The configured directory '" + (root.cfg.wallpaperDirectory ?? "") + "' does not exist.\nCheck the path in Wallpaper Carousel settings."
  • (H) Line 590: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Press Escape to close"
  • (H) Line 598: Do not use hardcoded values, always prefer to use the Style singleton instead
+            spacing: 12
  • (H) Line 615: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+                text: "Press Escape to close"

File: wallpaper-carousel/Settings.qml

  • (H) Line 8: Do not use hardcoded values, always prefer to use the Style singleton instead
+    spacing: 12
  • (H) Line 33: Do not use hardcoded values, always prefer to use the Style singleton instead
+        spacing: 2
  • (H) Line 65: Do not use hardcoded values, always prefer to use the Style singleton instead
+        spacing: 2
  • (H) Line 88: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "General"; font.bold: true; font.pixelSize: 14 }
  • (H) Line 90: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Wallpaper Directory"; font.bold: true }
  • (H) Line 98: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        text: "Override the wallpaper directory. Leave empty to follow the current wallpaper's directory."
  • (H) Line 103: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Carousel Mode"
  • (H) Line 104: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Standard stops at the edges. Wrap loops the index. Infinite shows a seamless repeating view."
  • (H) Line 107: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Standard", value: "standard" },
  • (H) Line 108: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Wrap",     value: "wrap"     },
  • (H) Line 109: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Infinite", value: "infinite" }
  • (H) Line 114: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Visual"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 117: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Background Dimming"; description: "Opacity of the dark overlay behind the carousel."
  • (H) Line 122: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Border Width"; description: "Width of the skewed border around thumbnails."
  • (H) Line 127: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Corner Radius"; description: "Corner radius of thumbnails. Set to 0 to disable."
  • (H) Line 132: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Size"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 135: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Width"; description: "Width of each wallpaper thumbnail."
  • (H) Line 140: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Height"; description: "Height of each wallpaper thumbnail."
  • (H) Line 145: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Center Tile Zoom"; description: "Size of the centered tile relative to the surrounding tiles."
  • (H) Line 150: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+    Label { text: "Expansion"; font.bold: true; font.pixelSize: 14; Layout.topMargin: 8 }
  • (H) Line 153: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expand Selected"
  • (H) Line 154: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Expand the centered tile's width to reveal more of the image."
  • (H) Line 157: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Disabled", value: "false" },
  • (H) Line 158: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Enabled",  value: "true"  }
  • (H) Line 163: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expansion Amount"; description: "Width multiplier applied when the centered tile is expanded."
  • (H) Line 168: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold to Expand"
  • (H) Line 169: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Dwell on a tile to trigger a large immersive preview."
  • (H) Line 172: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Disabled", value: "false" },
  • (H) Line 173: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { text: "Enabled",  value: "true"  }
  • (H) Line 178: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Coverage"; description: "Screen coverage for the hold preview."
  • (H) Line 183: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Delay"; description: "Time to dwell on a tile before the preview activates."

File: wallpaper-carousel/WallpaperCarouselSettings.qml

  • (H) Line 70: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Wallpaper Directory"
  • (H) Line 71: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Override the wallpaper directory. Leave empty to follow system wallpaper."
  • (H) Line 78: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Carousel Mode"
  • (H) Line 79: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Standard stops at the edges. Wrap loops the index. Infinite shows a seamless repeating view."
  • (H) Line 82: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Standard", value: "standard" },
  • (H) Line 83: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Wrap", value: "wrap" },
  • (H) Line 84: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Infinite", value: "infinite" }
  • (H) Line 92: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Background Dimming"
  • (H) Line 100: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Border Width"
  • (H) Line 107: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Corner Radius"
  • (H) Line 118: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Width"
  • (H) Line 125: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Item Height"
  • (H) Line 132: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Center Tile Zoom"
  • (H) Line 143: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expand Selected"
  • (H) Line 144: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Expand the centered tile's width to reveal more of the image."
  • (H) Line 147: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Disabled", value: "false" },
  • (H) Line 148: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Enabled", value: "true" }
  • (H) Line 153: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Expansion Amount"
  • (H) Line 161: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold to Expand"
  • (H) Line 162: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        description: "Dwell on a tile to trigger a large immersive preview."
  • (H) Line 165: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Disabled", value: "false" },
  • (H) Line 166: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+            { label: "Enabled", value: "true" }
  • (H) Line 171: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Coverage"
  • (H) Line 178: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")
+        label: "Hold Delay"

@spiros132 spiros132 marked this pull request as draft May 4, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants