settings: ui polish, "groups" are using secondary palette color

Author: ItsLemmy

assets/translations/en.json

@@ -1462,11 +1462,11 @@
           "placeholder": "gimp {path} or satty -f -"
         },
         "osd-position": {
-          "label": "OSD Position",
+          "label": "Screen Position",
           "description": "Screen position for OSD popups"
         },
         "osd-lock-keys": {
-          "label": "Lock Keys OSD",
+          "label": "Lock Keys",
           "description": "Show OSD popups for Caps Lock, Num Lock, and Scroll Lock changes"
         }
       },
@@ -1901,15 +1901,15 @@
           "description": "Enable the built-in notification daemon"
         },
         "position": {
-          "label": "Toast Position",
+          "label": "Screen Position",
           "description": "Screen position for notification toasts"
         },
         "layer": {
           "label": "Wayland Layer",
           "description": "Choose whether toasts use the top or overlay layer"
         },
         "toast-opacity": {
-          "label": "Toast Opacity",
+          "label": "Background Opacity",
           "description": "Background opacity of notification toasts"
         },
         "offset-x": {

src/shell/settings/bar_widget_editor.cpp

@@ -82,8 +82,7 @@ namespace settings {
       wrap->setGap(Style::spaceXs * scale);
       wrap->setPadding(Style::spaceSm * scale, 0.0f, 0.0f, 0.0f);
       wrap->addChild(std::make_unique<Separator>());
-      wrap->addChild(
-          makeLabel(title, Style::fontSizeCaption * scale, colorSpecFromRole(ColorRole::OnSurfaceVariant), true));
+      wrap->addChild(makeLabel(title, Style::fontSizeCaption * scale, colorSpecFromRole(ColorRole::Secondary), true));
       return wrap;
     }
 

src/shell/settings/settings_content.cpp

@@ -907,11 +907,10 @@ namespace settings {
         groupHeader->setPadding(Style::spaceSm * scale, 0.0f, 0.0f, 0.0f);
         groupHeader->addChild(std::make_unique<Separator>());
         groupHeader->addChild(
-            makeLabel(title, Style::fontSizeBody * scale, colorSpecFromRole(ColorRole::OnSurfaceVariant), true));
+            makeLabel(title, Style::fontSizeBody * scale, colorSpecFromRole(ColorRole::Secondary), true));
         section.addChild(std::move(groupHeader));
       } else {
-        section.addChild(
-            makeLabel(title, Style::fontSizeBody * scale, colorSpecFromRole(ColorRole::OnSurfaceVariant), true));
+        section.addChild(makeLabel(title, Style::fontSizeBody * scale, colorSpecFromRole(ColorRole::Secondary), true));
       }
     };