fix(launcher): use grid cell height for list result rows#3293
Merged
Ly-sec merged 1 commit intoJul 7, 2026
Conversation
Bind each result row to the tile's actual height instead of recomputing the row height independently, keeping row sizing consistent with the grid cell height.
Member
|
Hey @TotalyEnglizLitrate , that looks good to me. I'll merge it, thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind each result row to the tile's actual height instead of recomputing the row height independently, keeping row sizing consistent with the grid cell height.
Motivation
List rows recomputed their own height independently of the grid cell height, and resized late after launch leaving selection/hover highlight boxes mismatched with the actual row bounds. Binding each row to the tile's actual height keeps sizing consistent, avoiding the post-launch resize and fixes the highlight boxes.
Type of Change
Related Issue
Closes #3285
Testing
opened launcher to verify no post-launch resize and no overlap between selection/hover highlights
Manual Coverage
Screenshots / Videos
2026-07-06_20-20-59.mp4
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
N/A