Skip to content

Commit 7dc236c

Browse files
committed
fix: remove os.machine, fix #994
Signed-off-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
1 parent 76d54b2 commit 7dc236c

4 files changed

Lines changed: 11 additions & 2 deletions

File tree

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
fail-fast: false
6666
matrix:
6767
os: [ubuntu-latest, macos-latest]
68-
node-version: ['lts/*']
68+
node-version: [16, 18, 20, 22, 'lts/*']
6969

7070
steps:
7171
- name: Checkout

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
# Changelog
22

3+
### 3.5.4
4+
5+
- fix the `os.machine` breaking some dependents, fix [#994](https://github.com/node-formidable/formidable/issues/994)
6+
- add Node 16, 18, 20, 22 to CI/CD
7+
38
### 3.5.3
49

10+
- security report by ZAST.AI help for some vulnerabilities addressing (primarily the random names generation)
511
- update failing tests
612
- update CI/CD workflows and actions;
713
- update CodeQL github action for security analysis

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@
9090
"rollup": "^3.25.3",
9191
"supertest": "6.1.6"
9292
},
93+
"engines": {
94+
"node": ">=14.0.0"
95+
},
9396
"jest": {
9497
"verbose": true
9598
},

src/Formidable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import DummyParser from './parsers/Dummy.js';
1616
import MultipartParser from './parsers/Multipart.js';
1717
import { json, multipart, octetstream, querystring } from './plugins/index.js';
1818

19-
const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}-${os.machine()}`
19+
const CUID2_FINGERPRINT = `${process.env.NODE_ENV}-${os.platform()}-${os.hostname()}}`
2020
const createId = cuid2init({ length: 25, fingerprint: CUID2_FINGERPRINT.toLowerCase() });
2121

2222
const DEFAULT_OPTIONS = {

0 commit comments

Comments
 (0)