scripts should not read from env

chearon · chearon · commit 27c02c9ecc69 · 2018-11-07T20:37:46.000-05:00
diff --git a/ci/install.sh b/ci/install.sh
@@ -47,7 +47,7 @@ for ver in $NODEJS_VERSIONS; do
   if [ $? -eq 0 ]; then
     cd ..
     source ci/$OS/bundle.sh;
-    source ci/tarball.sh;
+    source ci/tarball.sh $CANVAS_PREBUILT_VERSION;
   else
     echo "error building in nodejs version $ver"
     cd ..
diff --git a/ci/tarball.sh b/ci/tarball.sh
@@ -1,4 +1,5 @@
 # Generate the node-gyp formatted filename from the node environment
+CANVAS_PREBUILT_VERSION=$1
 FILENAME=$(
   node -e "
     var p = process, v = p.versions, pkg = require('./package.json'), libc = require('detect-libc').family || 'unknown';

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`# Generate the node-gyp formatted filename from the node environment`
	`2`	`+CANVAS_PREBUILT_VERSION=$1`
`2`	`3`	`FILENAME=$(`
`3`	`4`	`node -e "`
`4`	`5`	`var p = process, v = p.versions, pkg = require('./package.json'), libc = require('detect-libc').family \|\| 'unknown';`