test: 💍 fix ref should use custom handler circular bug (#128)

Co-authored-by: hongcai.dhc <hongcai.dhc@alibaba-inc.com>

Author: denghongcai

lib/v1/decoder.js

@@ -529,7 +529,10 @@ proto.readList = proto.readArray;
 proto.readRef = function (withType) {
   var rid = this.readRefId();
   var obj = this.refMap[rid];
-  return handle(obj, withType);
+  if (!withType && obj && utils.hasOwnProperty(obj, '$')) {
+    return handle(obj, withType);
+  }
+  return obj;
 };
 
 /**

test/custom_handler.test.js

@@ -93,6 +93,34 @@ describe('utils.test.js', function () {
       assert.deepEqual(output, {'1': { value: '100.06'}, '2': { value: '100.06' }});
   	});
 
+    it('should decode with custom handler if has ref and has circular ref', function () {
+      var circularObj = { value: '100.06' };
+      circularObj.ref = circularObj;
+  		hessian.registerDecodeHandler('java.test.circular', function (result) {
+        // must modify result in place to avoid circular problem
+        return {
+          $class: result.$class,
+          $: result.$,
+        };
+  		});
+      var o = { $class: 'java.test.circular', $: circularObj };
+      var map = new Map();
+      map.set(1, o);
+      map.set(2, o);
+      var buf = hessian.encode({
+        $class: 'java.util.HashMap',
+        $: map
+      }, '2.0');
+      var output = hessian.decode(buf, '2.0');
+      /**
+       * fix problem like ref object reuse
+       */
+      assert(output[1].value === '100.06');
+      assert(output[2].value === '100.06');
+      assert(output[1].ref.ref.ref.ref.value === '100.06');
+      hessian.deregisterDecodeHandler('java.test.circular');
+  	});
+
   	if (!supportES6Map) {
   		return;
   	}