Skip to content

fix: should not throw when fetch a Request with post #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
killagu merged 2 commits into from
Dec 11, 2024
Merged

fix: should not throw when fetch a Request with post #563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1019228
fix: should not throw when fetch a Request with post
MadCcc Dec 11, 2024
f113c89
fix: remove duplicate init
MadCcc Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ test/fixtures/ts-cjs-es2021/*.js
test/fixtures/ts-esm/*.js
.eslintcache
.tshy*
.idea/
2 changes: 1 addition & 1 deletion src/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export class FetchFactory {
} as any as RawResponseWithMeta;
try {
await FetchFactory.#opaqueLocalStorage.run(internalOpaque, async () => {
res = await UndiciFetch(input, init);
res = await UndiciFetch(request, init);
Copy link
Copy Markdown
Member

@killagu killagu Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init 还需要吗？init 已经传到 request 里了。

Copy link
Copy Markdown
Contributor Author

@MadCcc MadCcc Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实应该不用了，我改改

Copy link
Copy Markdown
Member

@fengmk2 fengmk2 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复了提交一下，然后就可以合并了。

});
} catch (e: any) {
updateSocketInfo(socketInfo, internalOpaque, e);
Expand Down
11 changes: 11 additions & 0 deletions test/fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
fetch, FetchDiagnosticsMessage, FetchFactory, FetchResponseDiagnosticsMessage,
} from '../src/fetch.js';
import { RequestDiagnosticsMessage, ResponseDiagnosticsMessage } from '../src/HttpClient.js';
import { Request } from 'undici';

describe('fetch.test.ts', () => {
let close: any;
Expand Down Expand Up @@ -109,4 +110,14 @@ describe('fetch.test.ts', () => {
assert(stats);
assert(Object.keys(stats).length > 0);
});

it('fetch request with post should work', async () => {
await assert.doesNotReject(async () => {
const request = new Request(_url, {
method: 'POST',
body: 'test-body',
});
await fetch(request);
}, /Cannot construct a Request with a Request object that has already been used/);
});
});