Merge pull request #439 from node-oauth/feature/replace-eslint-with-biome

Replace eslint with biome

Author: jankapunkt

.eslintignore

@@ -14,7 +14,7 @@ on:
 
 jobs:
   lint:
-    name: Javascript standard lint
+    name: Javascript Biome lint/format
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -28,8 +28,10 @@ jobs:
         with:
           node-version: 24
           cache: npm
-      - run: npm clean-install
-      - run: npm run lint
+      - run: |
+          npm clean-install
+          npm run lint
+          npm run format
 
   unittest:
     name: unit tests

.eslintrc

@@ -5,12 +5,12 @@ Complete, compliant and well tested module for implementing an OAuth2 server in
 
 [![Tests](https://github.com/node-oauth/node-oauth2-server/actions/workflows/tests.yml/badge.svg)](https://github.com/node-oauth/node-oauth2-server/actions/workflows/tests.yml)
 [![CodeQL Semantic Analysis](https://github.com/node-oauth/node-oauth2-server/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/node-oauth/node-oauth2-server/actions/workflows/codeql-analysis.yml)
-[![Tests for Release](https://github.com/node-oauth/node-oauth2-server/actions/workflows/tests-release.yml/badge.svg)](https://github.com/node-oauth/node-oauth2-server/actions/workflows/tests-release.yml)
 [![Documentation Status](https://readthedocs.org/projects/node-oauthoauth2-server/badge/?version=latest)](https://node-oauthoauth2-server.readthedocs.io/en/latest/?badge=latest)
 [![Project Status: Active – The project has reached a stable, usable state and is being actively developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
 [![npm Version](https://img.shields.io/npm/v/@node-oauth/oauth2-server?label=version)](https://www.npmjs.com/package/@node-oauth/oauth2-server)
 [![npm Downloads/Week](https://img.shields.io/npm/dw/@node-oauth/oauth2-server)](https://www.npmjs.com/package/@node-oauth/oauth2-server)
 [![GitHub License](https://img.shields.io/github/license/node-oauth/node-oauth2-server)](https://github.com/node-oauth/node-oauth2-server/blob/master/LICENSE)
+[![Formatted with Biome](https://img.shields.io/badge/Formatted_with-Biome-60a5fa?style=flat&logo=biome)](https://biomejs.dev/)
 
 NOTE: This project has been forked from [oauthjs/node-oauth2-server](https://github.com/oauthjs/node-oauth2-server) and is a continuation due to the project appearing to be abandoned. Please see [our issue board](https://github.com/node-oauth/node-oauth2-server/issues) to talk about next steps and the future of this project.
 

.github/workflows/tests.yml

@@ -0,0 +1,58 @@
+{
+	"$schema": "https://biomejs.dev/schemas/2.5.0/schema.json",
+	"vcs": {
+		"enabled": true,
+		"clientKind": "git",
+		"useIgnoreFile": true
+	},
+	"files": {
+		"ignoreUnknown": true,
+		"includes": ["index.js", "lib/**/*.js", "test/**/*.js"]
+	},
+	"formatter": {
+		"enabled": true
+	},
+	"linter": {
+		"enabled": true,
+		"rules": {
+			"preset": "recommended",
+			"suspicious": {
+				"noRedundantUseStrict": "off",
+				"noPrototypeBuiltins": "off",
+				"useIsArray": "off",
+				"noGlobalAssign": "off"
+			},
+			"complexity": {
+				"useArrowFunction": "off",
+				"useDateNow": "off",
+				"useOptionalChain": "off",
+				"useLiteralKeys": "off",
+				"noUselessThisAlias": "off"
+			},
+			"correctness": {
+				"noUnusedFunctionParameters": "off",
+				"noUnusedVariables": "off"
+			},
+			"style": {
+				"useNodejsImportProtocol": "off",
+				"useTemplate": "off"
+			}
+		}
+	},
+	"javascript": {
+		"formatter": {
+			"quoteStyle": "single",
+			"indentStyle": "space",
+			"trailingCommas": "all",
+			"lineWidth": 120
+		}
+	},
+	"assist": {
+		"enabled": true,
+		"actions": {
+			"source": {
+				"organizeImports": "on"
+			}
+		}
+	}
+}

README.md

@@ -32,4 +32,3 @@ exports.UnauthorizedClientError = require('./lib/errors/unauthorized-client-erro
 exports.UnauthorizedRequestError = require('./lib/errors/unauthorized-request-error');
 exports.UnsupportedGrantTypeError = require('./lib/errors/unsupported-grant-type-error');
 exports.UnsupportedResponseTypeError = require('./lib/errors/unsupported-response-type-error');
-

biome.json

@@ -13,15 +13,15 @@ const OAuthError = require('./oauth-error');
  */
 class AccessDeniedError extends OAuthError {
   /**
-     * @constructor
-     * @param message {string}
-     * @param properties {object=}
-     */
+   * @constructor
+   * @param message {string}
+   * @param properties {object=}
+   */
   constructor(message, properties) {
     properties = {
       code: 400,
       name: 'access_denied',
-      ...properties
+      ...properties,
     };
 
     super(message, properties);

index.js

@@ -17,12 +17,12 @@ class InsufficientScopeError extends OAuthError {
    * @constructor
    * @param message {string}
    * @param properties {object=}
-     */
+   */
   constructor(message, properties) {
     properties = {
       code: 403,
       name: 'insufficient_scope',
-      ...properties
+      ...properties,
     };
 
     super(message, properties);

lib/errors/access-denied-error.js

@@ -16,12 +16,12 @@ class InvalidArgumentError extends OAuthError {
    * @constructor
    * @param message {string}
    * @param properties {object=}
-     */
+   */
   constructor(message, properties) {
     properties = {
       code: 500,
       name: 'invalid_argument',
-      ...properties
+      ...properties,
     };
 
     super(message, properties);

lib/errors/insufficient-scope-error.js

@@ -15,15 +15,15 @@ const OAuthError = require('./oauth-error');
 
 class InvalidClientError extends OAuthError {
   /**
-     * @constructor
-     * @param message {string}
-     * @param properties {object=}
-     */
+   * @constructor
+   * @param message {string}
+   * @param properties {object=}
+   */
   constructor(message, properties) {
     properties = {
       code: 400,
       name: 'invalid_client',
-      ...properties
+      ...properties,
     };
 
     super(message, properties);