Skip to content

Security: explicit string requirement for request parameters (client id, tokens etc.) #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jankapunkt wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Security: explicit string requirement for request parameters (client id, tokens etc.) #399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4a14f4
fix(tests): make required params strings
jankapunkt Jan 26, 2026
c76e4c0
refactor: use param-util for parameter type checks and conversions
jankapunkt Jan 29, 2026
11de06a
fix(tests): make compliance tests mixed using db ids as numbers and s…
jankapunkt Jan 29, 2026
f3d77ad
fix: support number and strings for id params but pass original param…
jankapunkt Jan 29, 2026
50adf11
fix: rename jsDoc comment model name on param-util.js
jankapunkt Jan 29, 2026
e51fc27
fix(test): use string based id in one compliance test for coverage
jankapunkt Jan 29, 2026
802546a
fix(tests): add missing tests for missing and invalid codes in Author…
jankapunkt Jan 29, 2026
f9a05dd
Merge branch 'master' into fix/tests-assert-string
jankapunkt Mar 19, 2026
aa88382
fix: stricter toString conversion for unsupported types
jankapunkt Mar 19, 2026
fd8f367
tests: update string asserter tests
jankapunkt Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/grant-types/authorization-code-grant-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class AuthorizationCodeGrantType extends AbstractGrantType {

const redirectUri = request.body.redirect_uri || request.query.redirect_uri;

if (!isFormat.uri(redirectUri)) {
if (!redirectUri || !isFormat.uri(redirectUri)) {
throw new InvalidRequestError('Invalid request: `redirect_uri` is not a valid URI');
}

Expand Down
Loading
Loading