Address coderabbit review

davidthornton · davidthornton · commit 384696d047bd · 2026-04-03T16:43:17.000+11:00
diff --git a/src/signed-xml.ts b/src/signed-xml.ts
@@ -1160,7 +1160,7 @@ export class SignedXml {
    * Adds all references to the SignedInfo after the signature placeholder is inserted.
    */
   private addAllReferences(doc: Document, signatureElem: Element, prefix?: string): void {
-    if (!utils.isArrayHasLength(this.references)) {
+    if (!utils.isArrayHasLength(this.references) && !utils.isArrayHasLength(this.attachmentReferences)) {
       return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1160,7 +1160,7 @@ export class SignedXml {`
`1160`	`1160`	`* Adds all references to the SignedInfo after the signature placeholder is inserted.`
`1161`	`1161`	`*/`
`1162`	`1162`	`private addAllReferences(doc: Document, signatureElem: Element, prefix?: string): void {`
`1163`		`- if (!utils.isArrayHasLength(this.references)) {`
	`1163`	`+ if (!utils.isArrayHasLength(this.references) && !utils.isArrayHasLength(this.attachmentReferences)) {`
`1164`	`1164`	`return;`
`1165`	`1165`	`}`
`1166`	`1166`