Skip to content

lookup: add yargs #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesleytodd wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

lookup: add yargs #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/lookup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,10 @@
"maintainers": ["einaros", "3rd-Eden", "lpinca"],
"scripts": ["test -- --timeout 30000"]
},
"yargs": {
"prefix": "v",
"maintainers": ["bcoe"]

@joyeecheung joyeecheung Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since yargs has released fixes to 17 and 16, it may be time to revisit this PR, although not necessarily for v18 due to #1106 (comment) . I am not sure if it's appropriate to sign other people up in this list without their explicit consent though, generally the maintainers need to be responsive to pings, which implies some workload. Maybe @shadowspawn would be interested as a contact?

@shadowspawn shadowspawn Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am intending v18 will be a suitable candidate after improvements to the build stability. I am willing to be the contact. (I had not proposed that yet as I have not done the stability improvements. 😄 )

The tests for yargs v17 are still broken on Node.js 26 because mocha@9.2.2 depends on (exactly) yargs@16.2.0, which is before the fix!

@shadowspawn shadowspawn Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"maintainers": ["bcoe"]
"maintainers": ["shadowspawn"]

},
"yeoman-generator": {
"prefix": "v",
"flaky": ["ppc", "rhel"],
Expand Down
Loading