fix(search): use advanced search#182
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GitHub agenda issues functionality to use GitHub's advanced search API instead of iterating through all organization repositories individually. This change improves performance by making a single search query instead of multiple repository-specific queries.
- Switched from repository iteration to GitHub search API with
advanced_search: true - Updated data structure from array of repo objects to a key-value object mapping
- Removed unused parameters and simplified function signatures
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/github.mjs | Replaces repository iteration with GitHub search API and updates return type |
| src/meeting.mjs | Updates function signature and data processing to handle new object structure |
| src/constants.mjs | Adds constant for repository URL prefix length used in URL parsing |
| create-node-meeting-artifacts.mjs | Removes unused meetingConfig parameter from function call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
Bump @ovflowd |
ovflowd
reviewed
Sep 27, 2025
ovflowd
reviewed
Sep 27, 2025
ovflowd
reviewed
Sep 27, 2025
ovflowd
approved these changes
Sep 27, 2025
ovflowd
left a comment
Member
There was a problem hiding this comment.
SGTM, but would love to have my comments replied at least :)
ovflowd
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ovflowd - This PR reduces the amount of times the GH API is called significantly by using advanced search