Skip to content

fix: turn off fail fast, let other wg run if one fails#184

Merged
ovflowd merged 1 commit into
nodejs:mainfrom
jonchurch:fail-fast-off
Sep 27, 2025
Merged

fix: turn off fail fast, let other wg run if one fails#184
ovflowd merged 1 commit into
nodejs:mainfrom
jonchurch:fail-fast-off

Conversation

@jonchurch

Copy link
Copy Markdown
Contributor

In the most recent scheduled run one of the groups failed, this causes all other items in the matrix to cancel, preventing the other wg meeting artifacts from being processed. (it was userfeedback, not finding the next calendar invite instance)

Turning off fail fast will allow other matrix members to still execute even if one has failed.

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@ovflowd

ovflowd commented Sep 27, 2025

Copy link
Copy Markdown
Member

TYSM for this change, I had no idea about this <3

@ovflowd ovflowd merged commit 8d99074 into nodejs:main Sep 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants