From 071f8d668ef240837baf16acfea60545fadd1c8a Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 27 Oct 2025 17:45:09 -0400 Subject: [PATCH 1/3] hotfix: de-require `dry_run` Removed 'required' property from 'dry_run' input. --- .github/workflows/create-meeting-artifacts-manual.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/create-meeting-artifacts-manual.yml b/.github/workflows/create-meeting-artifacts-manual.yml index 5b023c1..f061025 100644 --- a/.github/workflows/create-meeting-artifacts-manual.yml +++ b/.github/workflows/create-meeting-artifacts-manual.yml @@ -21,7 +21,6 @@ on: type: boolean description: 'Dry run?' default: false - required: true jobs: create-artifacts: From cd42fa993a7deb451d950c5a41cd190e3b20378e Mon Sep 17 00:00:00 2001 From: avivkeller Date: Mon, 27 Oct 2025 17:49:12 -0400 Subject: [PATCH 2/3] fixup! --- .../workflows/create-meeting-artifacts-manual.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/create-meeting-artifacts-manual.yml b/.github/workflows/create-meeting-artifacts-manual.yml index f061025..13c761f 100644 --- a/.github/workflows/create-meeting-artifacts-manual.yml +++ b/.github/workflows/create-meeting-artifacts-manual.yml @@ -41,7 +41,7 @@ jobs: - name: Read Meeting Variables id: read-vars run: | - meeting_group="${{ github.event.inputs.meeting_group }}" + meeting_group="${{ inputs.meeting_group }}" user=$(grep '^USER=' "templates/meeting_base_${meeting_group}" | cut -d'=' -f2 | xargs) echo "user=$user" >> $GITHUB_OUTPUT @@ -58,16 +58,20 @@ jobs: GITHUB_TOKEN: ${{ steps.app-token.outputs.token }} HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }} GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} - ADDITIONAL_ARGS: ${{ github.event.inputs.dry_run == 'true' && '--dry-run' || '' }} - run: node create-node-meeting-artifacts.mjs ${{ github.event.inputs.meeting_group }} --verbose $ADDITIONAL_ARGS + run: | + args="${{ inputs.meeting_group }} --verbose" + if [ "${{ inputs.dry_run }}" = "true" ]; then + args="$args --dry-run" + fi + node create-node-meeting-artifacts.mjs $args - name: Upload artifacts if: always() uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 with: - name: meeting-artifacts-${{ github.event.inputs.meeting_group || 'tsc' }} + name: meeting-artifacts-${{ inputs.meeting_group }} path: | ~/.make-node-meeting/ *.md retention-days: 7 - if-no-files-found: ignore + if-no-files-found: ignore \ No newline at end of file From 65eaef80ff97e342f3afdcb0d89db11b82732f4b Mon Sep 17 00:00:00 2001 From: avivkeller Date: Mon, 27 Oct 2025 17:50:29 -0400 Subject: [PATCH 3/3] fixup! --- .../workflows/create-meeting-artifacts-manual.yml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/create-meeting-artifacts-manual.yml b/.github/workflows/create-meeting-artifacts-manual.yml index 13c761f..433684f 100644 --- a/.github/workflows/create-meeting-artifacts-manual.yml +++ b/.github/workflows/create-meeting-artifacts-manual.yml @@ -58,20 +58,16 @@ jobs: GITHUB_TOKEN: ${{ steps.app-token.outputs.token }} HACKMD_API_TOKEN: ${{ secrets.HACKMD_API_TOKEN }} GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }} - run: | - args="${{ inputs.meeting_group }} --verbose" - if [ "${{ inputs.dry_run }}" = "true" ]; then - args="$args --dry-run" - fi - node create-node-meeting-artifacts.mjs $args + ADDITIONAL_ARGS: ${{ inputs.dry_run == 'true' && '--dry-run' || '' }} + run: node create-node-meeting-artifacts.mjs ${{ inputs.meeting_group }} --verbose $ADDITIONAL_ARGS - name: Upload artifacts if: always() uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 with: - name: meeting-artifacts-${{ inputs.meeting_group }} + name: meeting-artifacts-${{ inputs.meeting_group || 'tsc' }} path: | ~/.make-node-meeting/ *.md retention-days: 7 - if-no-files-found: ignore \ No newline at end of file + if-no-files-found: ignore