code review

Author: avivkeller

bin/commands/generate.mjs

@@ -29,15 +29,12 @@ export default new Command('generate')
 
   // Options that need to be converted into a configuration
   .addOption(
-    new Option(
-      '-i, --input <patterns...>',
-      'Input file patterns (glob)'
-    ).makeOptionMandatory()
+    new Option('-i, --input <patterns...>', 'Input file patterns (glob)')
   )
   .addOption(
-    new Option('-t, --target <generator...>', 'Target generator(s)')
-      .makeOptionMandatory()
-      .choices(Object.keys(publicGenerators))
+    new Option('-t, --target <generator...>', 'Target generator(s)').choices(
+      Object.keys(publicGenerators)
+    )
   )
   .addOption(
     new Option('--ignore <patterns...>', 'Ignore file patterns (glob)')

docs/configuration.md

@@ -61,7 +61,7 @@ The `global` object contains settings that apply to all generators unless overri
 | Property     | Type               | Description                                | Default                                            |
 | ------------ | ------------------ | ------------------------------------------ | -------------------------------------------------- |
 | `version`    | `string \| SemVer` | Documentation version                      | `process.version`                                  |
-| `minify`     | `boolean`          | Whether to minify output                   | `false`                                            |
+| `minify`     | `boolean`          | Whether to minify output                   | `true`                                            |
 | `repository` | `string`           | GitHub repository in `owner/repo` format   | `'nodejs/node'`                                    |
 | `ref`        | `string`           | Git reference (branch, tag, or commit SHA) | `'HEAD'`                                           |
 | `baseURL`    | `string \| URL`    | Base URL for documentation                 | `'https://nodejs.org/docs'`                        |

src/generators/sitemap/index.mjs

@@ -40,7 +40,7 @@ export default {
       .filter(entry => entry.heading.depth === 1)
       .map(entry => createPageSitemapEntry(entry, config.baseURL, lastmod));
 
-    const { href: loc } = new URL('/latest/api/', config.baseURL);
+    const { href: loc } = new URL('latest/api/', config.baseURL);
 
     /**
      * @typedef {import('./types').SitemapEntry}

src/generators/web/ui/components/NavBar.jsx

@@ -28,7 +28,7 @@ export default () => {
       />
       <a
         href={`https://github.com/${STATIC_DATA.repository}`}
-        aria-label={`${STATIC_DATA.title} Github`}
+        aria-label={`${STATIC_DATA.title} GitHub`}
         className={styles.ghIconWrapper}
       >
         <GitHubIcon />

src/utils/configuration/index.mjs

@@ -6,6 +6,7 @@ import { coerce } from 'semver';
 import { CHANGELOG_URL, populate } from './templates.mjs';
 import { allGenerators } from '../../generators/index.mjs';
 import { parseChangelog, parseIndex } from '../../parsers/markdown.mjs';
+import { enforceArray } from '../array.mjs';
 import { leftHandAssign } from '../generators.mjs';
 import { lazy } from '../misc.mjs';
 import { importFromURL } from '../url.mjs';
@@ -89,7 +90,7 @@ const merge = (objs, maxDepth, currentDepth = 0) => {
  * Loads a configuration file from a URL or file path.
  *
  * @param {string} filePath - The URL or file path to the configuration file
- * @returns {Promise<Object>} The imported configuration object, or an empty object if no path provided
+ * @returns {Promise<Partial<import('./types').Configuration>>} The imported configuration object, or an empty object if no path provided
  */
 export const loadConfigFile = filePath =>
   filePath ? importFromURL(filePath) : {};
@@ -154,6 +155,7 @@ export const createConfigFromCLIOptions = options => ({
  */
 export const createRunConfiguration = async options => {
   const config = await loadConfigFile(options.configFile);
+  config.target &&= enforceArray(config.target);
 
   // Merge with defaults
   // We set maxDepth as 2, as that's the depth of

src/utils/url.mjs

@@ -1,5 +1,6 @@
 import { readFile } from 'node:fs/promises';
-import { extname } from 'node:path';
+import { extname, isAbsolute, join } from 'node:path';
+import { pathToFileURL } from 'node:url';
 
 /**
  * Converts a value to a parsed URL object.
@@ -34,11 +35,13 @@ export const loadFromURL = async url => {
  * @returns {Promise<any>} The imported module
  */
 export const importFromURL = async url => {
-  const useJSONAssertion = extname(url) === '.json';
+  const useJSONAssertion = extname(String(parsed)) === '.json';
+
+  const parsed = toParsedURL(url);
 
   const imported = await import(
-    url,
-    useJSONAssertion && { with: { type: 'json' } }
+    parsed ?? pathToFileURL(isAbsolute(url) ? url : join(process.cwd(), url)),
+    useJSONAssertion ? { with: { type: 'json' } } : {}
   );
 
   return imported.default ?? imported;