refactor: review

Author: araujogui

src/generators/jsx-ast/index.mjs

@@ -23,6 +23,8 @@ export default {
 
   defaultConfiguration: {
     ref: 'main',
+    remoteConfig:
+      'https://raw.githubusercontent.com/nodejs/nodejs.org/main/apps/site/site.json',
   },
 
   /**

src/generators/jsx-ast/utils/buildContent.mjs

@@ -285,11 +285,13 @@ export const createDocumentLayout = (
   sideBarProps,
   metaBarProps,
   remark
-) =>
-  createTree('root', [
+) => {
+  const config = getConfig('jsx-ast');
+
+  return createTree('root', [
     createJSXElement(JSX_IMPORTS.AnnouncementBanner.name, {
-      remoteConfig: getConfig('web').remoteConfig,
-      versionMajor: getConfig('web').version?.major ?? null,
+      remoteConfig: config.remoteConfig,
+      versionMajor: config.version?.major ?? null,
     }),
     createJSXElement(JSX_IMPORTS.NavBar.name),
     createJSXElement(JSX_IMPORTS.Article.name, {
@@ -312,6 +314,7 @@ export const createDocumentLayout = (
       ],
     }),
   ]);
+};
 
 /**
  * @typedef {import('estree').Node & { data: ApiDocMetadataEntry }} JSXContent

src/generators/web/index.mjs

@@ -34,8 +34,6 @@ export default {
     imports: {
       '#config/Logo': '@node-core/ui-components/Common/NodejsLogo',
     },
-    remoteConfig:
-      'https://raw.githubusercontent.com/nodejs/nodejs.org/main/apps/site/site.json',
   },
 
   /**

src/generators/web/ui/components/AnnouncementBanner/index.jsx

@@ -34,13 +34,13 @@ export default ({ remoteConfig, versionMajor }) => {
 
         const active = [];
 
-        const globalBanner = config.global?.banner;
+        const globalBanner = config.websiteBanners?.index;
         if (globalBanner && isBannerActive(globalBanner)) {
           active.push(globalBanner);
         }
 
         if (versionMajor != null) {
-          const versionBanner = config[`v${versionMajor}`]?.banner;
+          const versionBanner = config.websiteBanners[`v${versionMajor}`];
           if (versionBanner && isBannerActive(versionBanner)) {
             active.push(versionBanner);
           }
@@ -64,11 +64,11 @@ export default ({ remoteConfig, versionMajor }) => {
           {banner.link ? (
             <a href={banner.link} target="_blank" rel="noopener noreferrer">
               {banner.text}
-              <ArrowUpRightIcon />
             </a>
           ) : (
             banner.text
           )}
+          {banner.link && <ArrowUpRightIcon />}
         </Banner>
       ))}
     </div>