fixup!

Author: avivkeller

src/generators/jsx-ast/__tests__/generate.test.mjs

@@ -67,32 +67,6 @@ describe('jsx-ast generate', () => {
     assert.equal('sectionEntries' in content, false);
   });
 
-  it('omits the core index entry and appends enabled synthetic pages', async () => {
-    await setConfig({});
-
-    const seenItems = [];
-    const results = await collect(
-      generate(
-        [createEntry('index', 'Index'), createEntry('fs', 'File system')],
-        createWorker(seenItems)
-      )
-    );
-
-    assert.deepEqual(
-      seenItems.map(({ head }) => head.api),
-      ['fs']
-    );
-    assert.deepEqual(
-      results.map(({ data }) => data.api),
-      ['fs', 'all', 'index', '404']
-    );
-
-    for (const entry of results.slice(1)) {
-      assert.equal(entry.data.synthetic, true);
-      assert.equal(entry.data.hideViewAs, true);
-    }
-  });
-
   it('respects jsx-ast synthetic page flags', async () => {
     await setConfig({});
 
@@ -111,11 +85,11 @@ describe('jsx-ast generate', () => {
 
     assert.deepEqual(
       seenItems.map(({ head }) => head.api),
-      ['fs']
+      ['index', 'fs']
     );
     assert.deepEqual(
       results.map(({ data }) => data.api),
-      ['fs']
+      ['index', 'fs']
     );
   });
 });

src/generators/jsx-ast/utils/synthetic/__tests__/404.test.mjs

@@ -12,7 +12,6 @@ describe('buildNotFoundPage', () => {
     assert.equal(head.basename, '404');
     assert.equal(head.heading.data.name, 'Page Not Found');
     assert.equal(head.synthetic, true);
-    assert.equal(head.hideViewAs, true);
   });
 
   it('produces a single synthetic entry with a not-found paragraph', () => {

src/generators/jsx-ast/utils/synthetic/__tests__/all.test.mjs

@@ -12,7 +12,6 @@ describe('buildAllPage', () => {
     assert.equal(head.basename, 'all');
     assert.equal(head.heading.data.name, 'All');
     assert.equal(head.synthetic, true);
-    assert.equal(head.hideViewAs, true);
   });
 
   it('forwards the input entries as the page entries', () => {

src/generators/jsx-ast/utils/synthetic/__tests__/index.test.mjs

@@ -29,7 +29,6 @@ describe('buildIndexPage', () => {
     assert.equal(head.basename, 'index');
     assert.equal(head.heading.data.name, 'Index');
     assert.equal(head.synthetic, true);
-    assert.equal(head.hideViewAs, true);
   });
 });
 

src/generators/jsx-ast/utils/synthetic/__tests__/synthetic.test.mjs

@@ -16,7 +16,6 @@ describe('createSyntheticHead', () => {
     const head = createSyntheticHead('index', 'Index');
 
     assert.equal(head.synthetic, true);
-    assert.equal(head.hideViewAs, true);
   });
 
   it('produces a depth-1 heading whose data is consistent with the name', () => {
@@ -66,6 +65,5 @@ describe('wrapAsEntry', () => {
     assert.equal(entry.path, head.path);
     assert.equal(entry.basename, head.basename);
     assert.equal(entry.synthetic, true);
-    assert.equal(entry.hideViewAs, true);
   });
 });

src/generators/jsx-ast/utils/synthetic/synthetic.mjs

@@ -15,7 +15,6 @@ export const createSyntheticHead = (api, name) => ({
   path: `/${api}`,
   basename: api,
   synthetic: true,
-  hideViewAs: true,
   heading: {
     type: 'heading',
     depth: 1,

src/generators/metadata/types.d.ts

@@ -128,8 +128,6 @@ export interface MetadataEntry extends YAMLProperties {
   basename: string;
   /** Whether this page was generated by a downstream generator. */
   synthetic?: boolean;
-  /** Whether the default web MetaBar should omit alternate-format links. */
-  hideViewAs?: boolean;
   /** Processed heading with metadata */
   heading: HeadingNode;
   /** Stability classification information */

src/generators/web/ui/components/MetaBar/index.jsx

@@ -71,7 +71,7 @@ export default ({ metadata, headings = [], readingTime }) => {
       items={{
         'Reading Time': readingTime,
         'Added In': metadata.added ?? metadata.introduced_in,
-        'View As': !metadata.hideViewAs && (
+        'View As': !metadata.synthetic && (
           <ol>
             {viewAs.map(([viewTitle, path]) => {
               const Icon = iconMap[viewTitle];
@@ -88,7 +88,7 @@ export default ({ metadata, headings = [], readingTime }) => {
             })}
           </ol>
         ),
-        Contribute: (
+        Contribute: !metadata.synthetic && (
           <>
             <GitHubIcon className="fill-neutral-700 dark:fill-neutral-100" />