Skip to content

feat(generator/orama-db): introduce#213

Merged
avivkeller merged 5 commits into
mainfrom
AugustinMauroy/augustinmauroy-workspace-generator-orama-db
Mar 22, 2025
Merged

feat(generator/orama-db): introduce#213
avivkeller merged 5 commits into
mainfrom
AugustinMauroy/augustinmauroy-workspace-generator-orama-db

Conversation

@AugustinMauroy

@AugustinMauroy AugustinMauroy commented Mar 18, 2025

Copy link
Copy Markdown
Member

This pull request introduces a new generator for creating an Orama database for the API documentation. The changes include adding new dependencies, importing and integrating the new generator, and implementing the generator logic.

close #65

Note

The output of v22.11.0 is 3Ko

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 18, 2025 09:21
@AugustinMauroy AugustinMauroy changed the title Add Orama db generator feat(generator/orama-db): introduce Mar 18, 2025
Comment thread src/generators/orama-db/index.mjs
Comment thread src/generators/orama-db/index.mjs
Comment thread src/generators/orama-db/index.mjs Outdated
Co-Authored-By: Caner Akdas <canerakdas@gmail.com>
@flakey5

flakey5 commented Mar 18, 2025

Copy link
Copy Markdown
Member

One thing to note is we probably will want this to be updated to use the new json generator apis when that's introduced (will have the pr in a week or two ish). It also might just make sense to copy the used portions of the legacy json generator into the utils for this one, since I'm not sure what we're going to do with the legacy generators once we have the redesigned ones

@AugustinMauroy

Copy link
Copy Markdown
Member Author

Hummm intresting should I put this pr in draft or land it with legacy JSON ?

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd

ovflowd commented Mar 22, 2025

Copy link
Copy Markdown
Member

Hummm intresting should I put this pr in draft or land it with legacy JSON ?

We can merge as it is and create a follow-up task imo

@avivkeller avivkeller merged commit a691789 into main Mar 22, 2025
@AugustinMauroy AugustinMauroy deleted the AugustinMauroy/augustinmauroy-workspace-generator-orama-db branch March 22, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add orama-db generator

6 participants