-
Notifications
You must be signed in to change notification settings - Fork 45
feat: create sitemap generator #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
8d07613
18c9357
914652c
6fa782a
71b6c24
21ad2b9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import { readFile, writeFile } from 'node:fs/promises'; | ||
| import { join } from 'node:path'; | ||
|
|
||
| import dedent from 'dedent'; | ||
|
|
||
| import { BASE_URL } from '../../constants.mjs'; | ||
| import { buildApiDocUrl } from './utils/buildApiDocUrl.mjs'; | ||
|
|
||
| /** | ||
| * This generator generates a sitemap.xml file for search engine optimization | ||
| * | ||
| * @typedef {Array<ApiDocMetadataEntry>} Input | ||
| * | ||
| * @type {GeneratorMetadata<Input, string>} | ||
| */ | ||
| export default { | ||
| name: 'sitemap', | ||
|
|
||
| version: '1.0.0', | ||
|
|
||
| description: 'Generates a sitemap.xml file for search engine optimization', | ||
|
|
||
| dependsOn: 'metadata', | ||
|
|
||
| /** | ||
| * Generates a sitemap.xml file | ||
| * | ||
| * @param {Input} entries | ||
| * @param {Partial<GeneratorOptions>} options | ||
| * @returns {Promise<string>} | ||
| */ | ||
| async generate(entries, { output }) { | ||
| const lastmod = new Date().toISOString().split('T')[0]; | ||
|
|
||
| const apiPages = entries | ||
| .filter(entry => entry.heading.depth === 1) | ||
| .map(entry => buildApiDocUrl(entry, lastmod)); | ||
|
|
||
| apiPages.push({ | ||
| loc: new URL('/docs/latest/api/', BASE_URL).href, | ||
|
araujogui marked this conversation as resolved.
Outdated
|
||
| lastmod, | ||
| changefreq: 'daily', | ||
| priority: '1.0', | ||
| }); | ||
|
|
||
| const template = await readFile( | ||
| join(import.meta.dirname, 'template.xml'), | ||
| 'utf-8' | ||
| ); | ||
|
|
||
| const urlset = apiPages | ||
| .map( | ||
| page => dedent` | ||
| <url> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: use template files for this and then do simple key->value substitution. Or use proper rss/feed libraries OR xml libraries.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
You can probably use hast (but I'm also fine with it this way), seeing as the majority of it is a template
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we use hast, we are probably going to need https://github.com/syntax-tree/hast-util-to-xast too
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm fine with whatever that uses the least amount of dependencies. We can also just use yet another template file, we can also simply use another dependency, like the xast one, or rss/feeds or whatever.
araujogui marked this conversation as resolved.
Outdated
|
||
| <loc>${page.loc}</loc> | ||
| <lastmod>${page.lastmod}</lastmod> | ||
| <changefreq>${page.changefreq}</changefreq> | ||
| <priority>${page.priority}</priority> | ||
| </url> | ||
| ` | ||
| ) | ||
| .join('\n'); | ||
|
|
||
| const sitemap = template.replace('__URLSET__', urlset); | ||
|
|
||
| if (output) { | ||
|
avivkeller marked this conversation as resolved.
Outdated
|
||
| await writeFile(join(output, 'sitemap.xml'), sitemap, 'utf-8'); | ||
| } | ||
|
|
||
| return sitemap; | ||
| }, | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> | ||
| __URLSET__ | ||
| </urlset> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| export interface SitemapUrl { | ||
|
araujogui marked this conversation as resolved.
Outdated
|
||
| loc: string; | ||
| lastmod?: string; | ||
| changefreq?: | ||
| | 'always' | ||
| | 'hourly' | ||
| | 'daily' | ||
| | 'weekly' | ||
| | 'monthly' | ||
| | 'yearly' | ||
| | 'never'; | ||
| priority?: string; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { buildApiDocURL } from '../../../utils/url.mjs'; | ||
|
|
||
| /** | ||
| * Builds an API doc sitemap url. | ||
| * | ||
| * @param {ApiDocMetadataEntry} entry | ||
| * @param {string} lastmod | ||
| * @returns {import('../types').SitemapUrl} | ||
| */ | ||
| export const buildApiDocUrl = (entry, lastmod) => { | ||
| const { href } = buildApiDocURL(entry, true); | ||
|
|
||
| return { loc: href, lastmod, changefreq: 'weekly', priority: '0.8' }; | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { describe, it } from 'node:test'; | ||
|
|
||
| import { buildApiDocURL } from '../url.mjs'; | ||
|
|
||
| const BASE = 'https://nodejs.org/'; | ||
|
|
||
| describe('buildApiDocURL', () => { | ||
| it('builds markdown doc URLs from doc/ sources', () => { | ||
| const entry = { api_doc_source: 'doc/api/fs.md' }; | ||
|
|
||
| const result = buildApiDocURL(entry); | ||
|
|
||
| assert.equal(result.href, `${BASE}docs/latest/api/fs.md`); | ||
| }); | ||
|
|
||
| it('builds html doc URLs when requested', () => { | ||
| const entry = { api_doc_source: 'doc/api/path.md' }; | ||
|
|
||
| const result = buildApiDocURL(entry, true); | ||
|
|
||
| assert.equal(result.href, `${BASE}docs/latest/api/path.html`); | ||
| }); | ||
|
|
||
| it('leaves non doc/ sources untouched', () => { | ||
| const entry = { api_doc_source: 'api/crypto.md' }; | ||
|
|
||
| const result = buildApiDocURL(entry); | ||
|
|
||
| assert.equal(result.href, `${BASE}api/crypto.md`); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { BASE_URL } from '../constants.mjs'; | ||
|
|
||
| /** | ||
| * Builds the url of a api doc entry. | ||
| * | ||
| * @param {ApiDocMetadataEntry} entry | ||
| * @param {boolean} [useHtml] | ||
| * @returns {URL} | ||
| */ | ||
| export const buildApiDocURL = (entry, useHtml = false) => { | ||
|
avivkeller marked this conversation as resolved.
|
||
| const path = entry.api_doc_source.replace(/^doc\//, '/docs/latest/'); | ||
|
|
||
| if (useHtml) { | ||
| const htmlPath = path.replace(/\.md$/, '.html'); | ||
|
araujogui marked this conversation as resolved.
Outdated
|
||
| return new URL(htmlPath, BASE_URL); | ||
| } | ||
|
|
||
| return new URL(path, BASE_URL); | ||
| }; | ||
Uh oh!
There was an error while loading. Please reload this page.