Skip to content

fix(legacy-json): use leftHandAssign in more cases #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 5 commits into from
Dec 20, 2025
Merged

fix(legacy-json): use leftHandAssign in more cases #525

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea95b66
fix(legacy-json): don't double-signature ctors
avivkeller Dec 19, 2025
4b87c4d
fixup!
avivkeller Dec 19, 2025
5e17d0c
fixup!
avivkeller Dec 19, 2025
62a388c
fixup!
avivkeller Dec 19, 2025
eaaaac7
fixup!
avivkeller Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/generators/legacy-json/utils/parseList.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,14 @@ export function parseList(section, nodes) {

// Update the section based on its type and parsed values
switch (section.type) {
case 'ctor':
case 'ctor': {
const signature = parseSignature(section.textRaw, values);

Object.keys(signature).forEach(key => (section[key] ??= signature[key]));

Comment thread
avivkeller marked this conversation as resolved.
Outdated
break;
}
Comment thread
avivkeller marked this conversation as resolved.
Outdated

case 'classMethod':
case 'method':
// For methods and constructors, parse and attach signatures
Expand Down
Loading