fix: use dots in release tag and filename for ICU >= 78#96
Conversation
Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted to using dots in both the release tag (release-78.1) and the filename (icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in versions 69-77. URL format by version range: - v67-v68: release-67-1/icu4c-67.1-data-bin-l.zip (hyphens in tag, dots in file) - v69-v77: release-73-1/icu4c-73_1-data-bin-l.zip (hyphens in tag, underscores in file) - v78+: release-78.1/icu4c-78.1-data-bin-l.zip (dots in both)
|
Hi @srl295, really appreciate the quick review here 🙏 Just checking if you have any timeline in mind for merging this and publishing a new release. Happy to help with anything needed. |
|
@nschonni it's been a while since anyone released this. Anything new i need to know? |
|
Don't think I've ever released any of the NPM packages in this org before. Quick search I found https://github.com/nodejs/undici as another project that has some automation (and CI hardening) that might make sense here. edit: Make sense here, but not needed as part of this PR |
|
Ok sounds good. I can do a manual release at some point |
|
Hi! Just checking in on this PR in case there’s anything else needed from my side — happy to help if useful 🙂 Also, do you have an approximate idea of when the manual release might happen? Just asking to get a rough idea of the timeline on my end. Thanks again! |
|
Hi @srl295! Just doing a follow-up on this I know you mentioned doing a manual release at some point, and I completely understand things take time. The reason I keep asking is that this bug prevents I'm also happy to help with anything that might make the release process easier — testing, docs, automating the release, or anything else that would help move things along. Thanks so much for your time and effort on this! 🙏 |
srl295
left a comment
There was a problem hiding this comment.
remove the namespace so i can publish
hey, please remove the namespace so i can publish. |
|
@rubenaguadoc I can't work with this branch with the extra namespace. So i'm copying it to #107 |
|
Sorry about that @srl295 This change was originally intended as a workaround for our internal usage, and I published our forked version to the GitHub NPM registry so we could move forward on our side. I didn’t realize I had pushed the packaging-related changes on top of the existing PR branch. I’ve now reverted the branch to match the original state of the pull request, so it’s back to being clean and focused on the upstream changes only. Apologies for the confusion and the extra noise, and thanks for the review. |
|
@rubenaguadoc published 1.6.0 |
|
Thanks, @srl295. Confirmed, everything is working fine now. |
Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted to using dots in both the release tag (release-78.1) and the filename (icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in versions 69-77.
URL format by version range: