Skip to content

fix: use dots in release tag and filename for ICU >= 78#96

Merged
srl295 merged 1 commit into
nodejs:mainfrom
DPS-ES:main
Jun 17, 2026
Merged

fix: use dots in release tag and filename for ICU >= 78#96
srl295 merged 1 commit into
nodejs:mainfrom
DPS-ES:main

Conversation

@rubenaguadoc

Copy link
Copy Markdown
Contributor

Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted to using dots in both the release tag (release-78.1) and the filename (icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in versions 69-77.

URL format by version range:

  • v67-v68: release-67-1/icu4c-67.1-data-bin-l.zip (hyphens in tag, dots in file)
  • v69-v77: release-73-1/icu4c-73_1-data-bin-l.zip (hyphens in tag, underscores in file)
  • v78+: release-78.1/icu4c-78.1-data-bin-l.zip (dots in both)

Starting from ICU 78.1, the unicode-org/icu GitHub releases reverted
to using dots in both the release tag (release-78.1) and the filename
(icu4c-78.1-data-bin-l.zip), instead of hyphens/underscores used in
versions 69-77.

URL format by version range:
- v67-v68: release-67-1/icu4c-67.1-data-bin-l.zip (hyphens in tag, dots in file)
- v69-v77: release-73-1/icu4c-73_1-data-bin-l.zip (hyphens in tag, underscores in file)
- v78+:    release-78.1/icu4c-78.1-data-bin-l.zip (dots in both)
@rubenaguadoc

Copy link
Copy Markdown
Contributor Author

Hi @srl295, really appreciate the quick review here 🙏

Just checking if you have any timeline in mind for merging this and publishing a new release.
The issue affects npm install full-icu on Node.js 22.22.1+, so getting this fix out would unblock things on our side.

Happy to help with anything needed.

@srl295

srl295 commented May 5, 2026

Copy link
Copy Markdown
Member

@nschonni it's been a while since anyone released this. Anything new i need to know?

@nschonni

nschonni commented May 6, 2026

Copy link
Copy Markdown
Member

Don't think I've ever released any of the NPM packages in this org before. Quick search I found https://github.com/nodejs/undici as another project that has some automation (and CI hardening) that might make sense here.

edit: Make sense here, but not needed as part of this PR

@srl295

srl295 commented May 6, 2026

Copy link
Copy Markdown
Member

Ok sounds good. I can do a manual release at some point

@rubenaguadoc

Copy link
Copy Markdown
Contributor Author

Hi! Just checking in on this PR in case there’s anything else needed from my side — happy to help if useful 🙂

Also, do you have an approximate idea of when the manual release might happen? Just asking to get a rough idea of the timeline on my end.

Thanks again!

@rubenaguadoc

Copy link
Copy Markdown
Contributor Author

Hi @srl295!

Just doing a follow-up on this

I know you mentioned doing a manual release at some point, and I completely understand things take time.

The reason I keep asking is that this bug prevents npm install full-icu from working on Node.js 22.22.1+, which is blocking us (and likely other users) in production environments. Would you have any rough idea of when that manual release might happen, even just rough estimate?

I'm also happy to help with anything that might make the release process easier — testing, docs, automating the release, or anything else that would help move things along.

Thanks so much for your time and effort on this! 🙏

@srl295 srl295 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the namespace so i can publish

@srl295

srl295 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@rubenaguadoc

Hi @srl295!

Just doing a follow-up on this

I know you mentioned doing a manual release at some point, and I completely understand things take time.

The reason I keep asking is that this bug prevents npm install full-icu from working on Node.js 22.22.1+, which is blocking us (and likely other users) in production environments. Would you have any rough idea of when that manual release might happen, even just rough estimate?

I'm also happy to help with anything that might make the release process easier — testing, docs, automating the release, or anything else that would help move things along.

Thanks so much for your time and effort on this! 🙏

hey, please remove the namespace so i can publish.

@srl295

srl295 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@rubenaguadoc I can't work with this branch with the extra namespace. So i'm copying it to #107

@rubenaguadoc

Copy link
Copy Markdown
Contributor Author

Sorry about that @srl295

This change was originally intended as a workaround for our internal usage, and I published our forked version to the GitHub NPM registry so we could move forward on our side.

I didn’t realize I had pushed the packaging-related changes on top of the existing PR branch.

I’ve now reverted the branch to match the original state of the pull request, so it’s back to being clean and focused on the upstream changes only.

Apologies for the confusion and the extra noise, and thanks for the review.

@rubenaguadoc rubenaguadoc requested a review from srl295 June 17, 2026 14:41
@srl295 srl295 merged commit 2e673e0 into nodejs:main Jun 17, 2026
24 of 30 checks passed
@srl295

srl295 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@rubenaguadoc published 1.6.0

@rubenaguadoc

Copy link
Copy Markdown
Contributor Author

Thanks, @srl295.

Confirmed, everything is working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants