fix: ignore failure of GetCompilerPredefines#295
Merged
legendecas merged 3 commits intonodejs:mainfrom Jun 6, 2025
Merged
Conversation
|
Hi, Compilation now runs smoothly and just displays a warning (which is expected according to the PR): Any ETA regarding the next gyp-next and node-gyp releases ? |
legendecas
reviewed
May 28, 2025
Member
legendecas
left a comment
There was a problem hiding this comment.
Would you mind adding a test case covering that the command fails? Thank you!
Contributor
Author
|
Done. |
legendecas
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #294
fixes nodejs/node-gyp#3164