Skip to content

Commit a0757b9

Browse files
committed
npm v12 removes command-line options
1 parent c7c678f commit a0757b9

3 files changed

Lines changed: 13 additions & 21 deletions

File tree

.github/workflows/tests.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,9 @@ jobs:
169169
echo 'GYP_MSVS_OVERRIDE_PATH=C:\\Dummy' >> $Env:GITHUB_ENV
170170
- name: Run Python Tests
171171
run: python -m pytest
172-
- name: Run Tests (macOS or Linux)
173-
if: runner.os != 'Windows'
174-
shell: bash
175-
run: npm test --python="${pythonLocation}/python"
172+
- run: echo "pythonLocation=${pythonLocation}"
173+
- run: echo "env:pythonLocation=${env:pythonLocation}"
174+
- run: env
175+
- run: npm test
176176
env:
177177
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}
178-
- name: Run Tests (Windows)
179-
if: runner.os == 'Windows'
180-
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
181-
run: npm run test --python="${pythonLocation}\\python.exe"
182-
env:
183-
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.13') && '1' || '0' }}

.github/workflows/visual-studio.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ jobs:
3333
python-version: "3.x"
3434
- name: Install Dependencies
3535
run: npm install
36+
- run: echo "pythonLocation=${pythonLocation}"
37+
- run: echo "env:pythonLocation=${env:pythonLocation}"
38+
- run: env
3639
- name: Run Node tests
37-
shell: pwsh
38-
run: npm run test --python="${env:pythonLocation}\\python.exe" --msvs-version="${{ matrix.msvs-version }}"
40+
run: npm run test

gyp/.github/workflows/node-gyp.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,10 @@ jobs:
5757
run: |
5858
rm -rf node-gyp/gyp
5959
cp -r gyp-next node-gyp/gyp
60-
- name: Run tests (macOS or Linux)
61-
if: runner.os != 'Windows'
60+
- run: echo "pythonLocation=${pythonLocation}"
61+
- run: echo "env:pythonLocation=${env:pythonLocation}"
62+
- run: env
63+
- name: Run tests
6264
run: |
6365
cd node-gyp
64-
npm test --python="${pythonLocation}/python"
65-
- name: Run tests (Windows)
66-
if: runner.os == 'Windows'
67-
shell: pwsh
68-
run: |
69-
cd node-gyp
70-
npm run test --python="${env:pythonLocation}\\python.exe"
66+
npm test

0 commit comments

Comments
 (0)