chore: retry downloads on retryable errors#3308
Merged
lukekarrys merged 1 commit intonodejs:mainfrom Apr 25, 2026
Merged
Conversation
Assisted-by: Claude Opus 4.6 Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
lukekarrys
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Opus 4.6
Checklist
npm install && npm run lint && npm testpassesDescription of change
Fixes #2847
This is a reworking of #3298 after the changes in #3302 landed.
Retries downloads up to 3 times to ensure a transient network error (we've seen
ECONNRESETfrom time to time) doesn't cause the whole thing to fail. This will retry for retryable errors (including 429 and 500 response status codes), and I've added test coverage to validate the behavior.