src: fix external reference registration for new CFunction lifetime

joyeecheung · nodejs-github-bot · commit 2d09f04472ed · 2026-06-06T07:18:19.000Z
Signed-off-by: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
diff --git a/src/node_external_reference.h b/src/node_external_reference.h
@@ -43,9 +43,6 @@ class ExternalReferenceRegistry {
   // and the corresponding CFunctionInfo.
   void Register(const v8::CFunction& c_func) {
     RegisterT(&c_func);
-    // TODO(joyeecheung): remove below when V8 14.8 lands.
-    RegisterT(c_func.GetAddress());
-    RegisterT(c_func.GetTypeInfo());
   }
 
   // This can be called only once.

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,6 @@ class ExternalReferenceRegistry {`
`43`	`43`	`// and the corresponding CFunctionInfo.`
`44`	`44`	`void Register(const v8::CFunction& c_func) {`
`45`	`45`	`RegisterT(&c_func);`
`46`		`- // TODO(joyeecheung): remove below when V8 14.8 lands.`
`47`		`- RegisterT(c_func.GetAddress());`
`48`		`- RegisterT(c_func.GetTypeInfo());`
`49`	`46`	`}`
`50`	`47`
`51`	`48`	`// This can be called only once.`