test: cover invalid inspector network initiator stack

Author: GrinZero

test/cctest/inspector/test_node_protocol.cc

@@ -2,22 +2,12 @@
 #include "gtest/gtest.h"
 #include "inspector/node_json.h"
 #include "node/inspector/protocol/Protocol.h"
-#include "node/inspector/protocol/Runtime.h"
 
 namespace node {
 namespace inspector {
 namespace protocol {
 namespace {
 
-class MalformedSerializedValue : public Value {
- public:
-  MalformedSerializedValue() : Value(TypeObject) {}
-
-  void AppendSerialized(std::vector<uint8_t>* out) const override {
-    out->push_back(0xff);
-  }
-};
-
 TEST(InspectorProtocol, Utf8StringSerDes) {
   constexpr const char* kKey = "unicode_key";
   constexpr const char* kValue = "CJK 汉字 🍱 🧑‍🧑‍🧒‍🧒";
@@ -37,18 +27,6 @@ TEST(InspectorProtocol, Utf8StringSerDes) {
   CHECK_EQ(parsed_value, std::string(kValue));
 }
 
-TEST(InspectorProtocol, StackTraceImportRejectsMalformedBinary) {
-  MalformedSerializedValue value;
-  ErrorSupport errors;
-
-  auto stack = ValueConversions<
-      v8_inspector::protocol::Runtime::API::StackTrace>::fromValue(&value,
-                                                                   &errors);
-
-  EXPECT_EQ(stack, nullptr);
-  EXPECT_FALSE(errors.Errors().empty());
-}
-
 }  // namespace
 }  // namespace protocol
 }  // namespace inspector

test/parallel/test-inspector-emit-protocol-event-errors.js

@@ -171,6 +171,19 @@ const NETWORK_ERROR_CASES = [
     networkRequest({ request: omit(networkRequest().request, 'headers') }),
     'Missing request.headers in event',
   ],
+  [
+    'requestWillBeSent',
+    networkRequest({
+      initiator: {
+        type: 'script',
+        stack: {
+          callFrames: [],
+          unsupportedValue: 1n,
+        },
+      },
+    }),
+    'Invalid initiator.stack in event',
+  ],
 
   [
     'responseReceived',