fix: throw exception when EVPKeyPointer::NewRSA() fails

ndossche · ndossche · commit 09ed00251153 · 2026-02-23T22:53:29.000+01:00
diff --git a/src/crypto/crypto_rsa.cc b/src/crypto/crypto_rsa.cc
@@ -440,7 +440,10 @@ KeyObjectData ImportJWKRsaKey(Environment* env,
   }
 
   auto pkey = EVPKeyPointer::NewRSA(std::move(rsa));
-  if (!pkey) return {};
+  if (!pkey) {
+    THROW_ERR_CRYPTO_OPERATION_FAILED(env, "Unable to create key pointer");
+    return {};
+  }
 
   return KeyObjectData::CreateAsymmetric(type, std::move(pkey));
 }

Original file line number	Diff line number	Diff line change
`@@ -440,7 +440,10 @@ KeyObjectData ImportJWKRsaKey(Environment* env,`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`auto pkey = EVPKeyPointer::NewRSA(std::move(rsa));`
`443`		`- if (!pkey) return {};`
	`443`	`+ if (!pkey) {`
	`444`	`+ THROW_ERR_CRYPTO_OPERATION_FAILED(env, "Unable to create key pointer");`
	`445`	`+ return {};`
	`446`	`+ }`
`444`	`447`
`445`	`448`	`return KeyObjectData::CreateAsymmetric(type, std::move(pkey));`
`446`	`449`	`}`