fixup! crypto: add raw key formats support to the KeyObject APIs

Author: panva

doc/api/crypto.md

@@ -313,19 +313,19 @@ const generated = await promisify(generateKeyPair)('ec', {
   namedCurve: 'P-256',
 });
 
-// Export the raw EC public key (compressed by default).
+// Export the raw EC public key (uncompressed by default).
 const rawPublicKey = generated.publicKey.export({ format: 'raw-public' });
 
 // The following is equivalent.
-const rawPublicKeyCompressed = generated.publicKey.export({
+const rawPublicKeyUncompressed = generated.publicKey.export({
   format: 'raw-public',
-  type: 'compressed',
+  type: 'uncompressed',
 });
 
-// Export uncompressed point format.
-const rawPublicKeyUncompressed = generated.publicKey.export({
+// Export compressed point format.
+const rawPublicKeyCompressed = generated.publicKey.export({
   format: 'raw-public',
-  type: 'uncompressed',
+  type: 'compressed',
 });
 
 // Export the raw EC private key.
@@ -2416,7 +2416,7 @@ For public keys, the following encoding options can be used:
   See [asymmetric key types][] for format support.
 * `type` {string} When `format` is `'pem'` or `'der'`, must be `'pkcs1'`
   (RSA only) or `'spki'`. For EC keys with `'raw-public'` format, may be
-  `'compressed'` (default) or `'uncompressed'`. Ignored when `format` is
+  `'uncompressed'` (default) or `'compressed'`. Ignored when `format` is
   `'jwk'`.
 
 For private keys, the following encoding options can be used:

lib/internal/crypto/keys.js

@@ -353,7 +353,7 @@ const {
           return this[kHandle].exportJwk({}, false);
         case 'raw-public': {
           if (this.asymmetricKeyType === 'ec') {
-            const { type = 'compressed' } = options;
+            const { type = 'uncompressed' } = options;
             validateOneOf(type, 'options.type', ['compressed', 'uncompressed']);
             const form = type === 'compressed' ?
               POINT_CONVERSION_COMPRESSED : POINT_CONVERSION_UNCOMPRESSED;

test/parallel/test-crypto-key-objects-raw.js

@@ -249,7 +249,7 @@ if (hasOpenSSL(3, 5)) {
   }
 }
 
-// EC: defaults to compressed, can be switched to uncompressed, both can be imported
+// EC: defaults to uncompressed, can be switched to compressed, both can be imported
 {
   const pubKeyObj = crypto.createPublicKey(
     fixtures.readKey('ec_p256_public.pem', 'ascii'));
@@ -258,8 +258,8 @@ if (hasOpenSSL(3, 5)) {
   const compressed = pubKeyObj.export({ format: 'raw-public', type: 'compressed' });
   const uncompressed = pubKeyObj.export({ format: 'raw-public', type: 'uncompressed' });
 
-  // Default is compressed
-  assert.deepStrictEqual(defaultExport, compressed);
+  // Default is uncompressed
+  assert.deepStrictEqual(defaultExport, uncompressed);
 
   // Compressed starts with 0x02 or 0x03 and is 33 bytes for P-256
   assert.strictEqual(compressed.byteLength, 33);