replace hardcoded limit size with constexpr variable for better maintainability

Author: mertcanaltin

src/node_sqlite.cc

@@ -147,7 +147,7 @@ struct LimitInfo {
   int sqlite_limit_id;
 };
 
-static constexpr std::array<LimitInfo, 11> kLimitMapping = {{
+static constexpr std::array<LimitInfo, kNumSqliteLimits> kLimitMapping = {{
     {"length", SQLITE_LIMIT_LENGTH},
     {"sqlLength", SQLITE_LIMIT_SQL_LENGTH},
     {"column", SQLITE_LIMIT_COLUMN},
@@ -754,7 +754,7 @@ Intercepted DatabaseSyncLimits::LimitsGetter(
   Utf8Value prop_name(isolate, property);
   const LimitInfo* limit_info = GetLimitInfoFromName(prop_name.ToStringView());
 
-  if (!limit_info) {
+  if (limit_info == nullptr) {
     return Intercepted::kNo;  // Unknown property, let default handling occur
   }
 
@@ -848,12 +848,12 @@ void DatabaseSyncLimits::LimitsEnumerator(
   Isolate* isolate = info.GetIsolate();
   LocalVector<Value> names(isolate);
 
-  for (size_t i = 0; i < kLimitMapping.size(); ++i) {
+  for (const auto& mapping : kLimitMapping) {
     Local<String> name;
     if (!String::NewFromUtf8(isolate,
-                            kLimitMapping[i].js_name.data(),
+                            mapping.js_name.data(),
                             NewStringType::kNormal,
-                            kLimitMapping[i].js_name.size())
+                            mapping.js_name.size())
             .ToLocal(&name)) {
       return;
     }

src/node_sqlite.h

@@ -16,6 +16,8 @@
 namespace node {
 namespace sqlite {
 
+constexpr size_t kNumSqliteLimits = 11;
+
 class DatabaseOpenConfiguration {
  public:
   explicit DatabaseOpenConfiguration(std::string&& location)
@@ -73,7 +75,7 @@ class DatabaseOpenConfiguration {
     initial_limits_.at(limit_id) = value;
   }
 
-  inline const std::array<std::optional<int>, SQLITE_LIMIT_TRIGGER_DEPTH + 1>&
+  inline const std::array<std::optional<int>, kNumSqliteLimits>&
   initial_limits() const {
     return initial_limits_;
   }
@@ -89,7 +91,7 @@ class DatabaseOpenConfiguration {
   bool allow_bare_named_params_ = true;
   bool allow_unknown_named_params_ = false;
   bool defensive_ = false;
-  std::array<std::optional<int>, SQLITE_LIMIT_TRIGGER_DEPTH + 1>
+  std::array<std::optional<int>, kNumSqliteLimits>
       initial_limits_;
 };