cli: add --experimental build flag

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

Author: ShogunPanda

common.gypi

@@ -15,6 +15,7 @@
     'python%': 'python',
 
     'node_shared%': 'false',
+    'node_enable_experimentals%': 0,
     'force_dynamic_crt%': 0,
     'node_use_v8_platform%': 'true',
     'node_use_bundled_v8%': 'true',
@@ -437,6 +438,9 @@
       }],
       # The defines bellow must include all things from the external_v8_defines
       # list in v8/BUILD.gn.
+      ['node_enable_experimentals==1', {
+        'defines': ['NODE_ENABLE_EXPERIMENTALS'],
+      }],
       ['v8_enable_v8_checks == 1', {
         'defines': ['V8_ENABLE_CHECKS'],
       }],

configure.py

@@ -797,6 +797,12 @@
     default=None,
     help='Enable the --trace-maps flag in V8 (use at your own risk)')
 
+parser.add_argument('--experimental',
+    action='store_true',
+    dest='experimental',
+    default=None,
+    help='Enable all experimental features by default')
+
 parser.add_argument('--experimental-enable-pointer-compression',
     action='store_true',
     dest='enable_pointer_compression',
@@ -1803,6 +1809,7 @@ def configure_node_cctest_sources(o):
 def configure_node(o):
   if options.dest_os == 'android':
     o['variables']['OS'] = 'android'
+  o['variables']['node_enable_experimentals'] = B(options.experimental)
   o['variables']['node_prefix'] = options.prefix
   o['variables']['node_install_npm'] = b(not options.without_npm)
   o['variables']['node_install_corepack'] = b(options.with_corepack)

src/node_options.h

@@ -112,6 +112,12 @@ class DebugOptions : public Options {
                     std::vector<std::string>* argv) override;
 };
 
+#ifdef NODE_ENABLE_EXPERIMENTALS
+#define EXPERIMENTAL_OPTION(name, default_value) bool name = true;
+#else
+#define EXPERIMENTAL_OPTION(name, default_value) bool name = default_value;
+#endif
+
 class EnvironmentOptions : public Options {
  public:
   bool abort_on_uncaught_exception = false;
@@ -122,19 +128,19 @@ class EnvironmentOptions : public Options {
   bool require_module = true;
   std::string dns_result_order;
   bool enable_source_maps = false;
-  bool experimental_addon_modules = false;
-  bool experimental_eventsource = false;
-  bool experimental_fetch = true;
-  bool experimental_ffi = false;
-  bool experimental_websocket = true;
-  bool experimental_sqlite = true;
-  bool experimental_stream_iter = false;
+  EXPERIMENTAL_OPTION(experimental_addon_modules, false)
+  EXPERIMENTAL_OPTION(experimental_eventsource, false)
+  EXPERIMENTAL_OPTION(experimental_fetch, true)
+  EXPERIMENTAL_OPTION(experimental_ffi, false)
+  EXPERIMENTAL_OPTION(experimental_websocket, true)
+  EXPERIMENTAL_OPTION(experimental_sqlite, true)
+  EXPERIMENTAL_OPTION(experimental_stream_iter, false)
   bool webstorage = HAVE_SQLITE;
-  bool experimental_quic = false;
+  EXPERIMENTAL_OPTION(experimental_quic, false)
   std::string localstorage_file;
-  bool experimental_global_navigator = true;
-  bool experimental_global_web_crypto = true;
-  bool experimental_import_meta_resolve = false;
+  EXPERIMENTAL_OPTION(experimental_global_navigator, true)
+  EXPERIMENTAL_OPTION(experimental_global_web_crypto, true)
+  EXPERIMENTAL_OPTION(experimental_import_meta_resolve, false)
   std::string input_type;  // Value of --input-type
   bool entry_is_url = false;
   bool permission = false;
@@ -148,8 +154,8 @@ class EnvironmentOptions : public Options {
   bool allow_wasi = false;
   bool allow_ffi = false;
   bool allow_worker_threads = false;
-  bool experimental_repl_await = true;
-  bool experimental_vm_modules = false;
+  EXPERIMENTAL_OPTION(experimental_repl_await, true)
+  EXPERIMENTAL_OPTION(experimental_vm_modules, false)
   bool async_context_frame = true;
   bool expose_internals = false;
   bool force_node_api_uncaught_exceptions_policy = false;
@@ -176,10 +182,10 @@ class EnvironmentOptions : public Options {
   uint64_t cpu_prof_interval = kDefaultCpuProfInterval;
   std::string cpu_prof_name;
   bool cpu_prof = false;
-  bool experimental_network_inspection = false;
-  bool experimental_worker_inspection = false;
-  bool experimental_storage_inspection = false;
-  bool experimental_inspector_network_resource = false;
+  EXPERIMENTAL_OPTION(experimental_network_inspection, false)
+  EXPERIMENTAL_OPTION(experimental_worker_inspection, false)
+  EXPERIMENTAL_OPTION(experimental_storage_inspection, false)
+  EXPERIMENTAL_OPTION(experimental_inspector_network_resource, false)
   std::string heap_prof_dir;
   std::string heap_prof_name;
   static const uint64_t kDefaultHeapProfInterval = 512 * 1024;
@@ -273,7 +279,7 @@ class EnvironmentOptions : public Options {
   bool report_exclude_env = false;
   bool report_exclude_network = false;
   std::string experimental_config_file_path;
-  bool experimental_default_config_file = false;
+  EXPERIMENTAL_OPTION(experimental_default_config_file, false)
 
   inline DebugOptions* get_debug_options() { return &debug_options_; }
   inline const DebugOptions& debug_options() const { return debug_options_; }