lib: fix lint errors after rebase

- Add missing Promise primordials to diagnostics_channel.js
- Fix JSDoc @returns and @param issues in metrics.js and object_identity.js
- Wrap setImmediate/Promise.then callbacks in mustCall in tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Qard

lib/diagnostics_channel.js

@@ -11,6 +11,10 @@ const {
   ObjectGetPrototypeOf,
   ObjectKeys,
   ObjectSetPrototypeOf,
+  Promise,
+  PromisePrototypeThen,
+  PromiseReject,
+  PromiseResolve,
   ReflectApply,
   SafeFinalizationRegistry,
   SafeMap,

lib/internal/perf/metrics.js

@@ -216,6 +216,7 @@ class MetricDescriptor {
   /**
    * Get the diagnostics_channel for this metric (lazily created).
    * Used by DiagnosticsChannelConsumer for efficient publishing.
+   * @returns {object}
    */
   get channel() {
     if (!this.#channel) {
@@ -764,6 +765,7 @@ const builtinAggregators = {
 
 /**
  * Get an aggregator by name or return custom aggregator object.
+ * @returns {object}
  */
 function getAggregator(aggregation) {
   if (typeof aggregation === 'string') {
@@ -1234,10 +1236,10 @@ class Consumer {
 
   /**
    * @param {object} config
-   * @param {string} [config.defaultAggregation='sum']
-   * @param {string} [config.defaultTemporality='cumulative']
-   * @param {boolean} [config.groupByAttributes=false] - Enable attribute differentiation
-   * @param {object} [config.metrics] - Per-metric configuration
+   * @param {string} [config.defaultAggregation] Default aggregation type.
+   * @param {string} [config.defaultTemporality] Default temporality mode.
+   * @param {boolean} [config.groupByAttributes] Enable attribute differentiation.
+   * @param {object} [config.metrics] Per-metric configuration.
    */
   constructor(config = kEmptyObject) {
     validateObject(config, 'config');

lib/internal/util/object_identity.js

@@ -214,7 +214,7 @@ class ObjectIdentity {
   /**
    * Create a new ObjectIdentity instance with configurable cache size.
    * @param {object} [options]
-   * @param {number} [options.sortedKeysCacheSize=1000] - Max sorted keys cache entries
+   * @param {number} [options.sortedKeysCacheSize] Max sorted keys cache entries.
    */
   constructor(options = kEmptyObject) {
     this.#sortedKeysCache = new SafeMap();

test/parallel/test-metrics-exemplar-asynclocalstorage.js

@@ -1,6 +1,6 @@
 // Flags: --expose-internals
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('node:assert');
 const { AsyncLocalStorage } = require('node:async_hooks');
 const { create, createConsumer, ReservoirSampler } = require('internal/perf/metrics');
@@ -205,7 +205,7 @@ function extractTraceContext(attributes) {
     promises.push(promise);
   }
 
-  Promise.all(promises).then(() => {
+  Promise.all(promises).then(common.mustCall(() => {
     const snapshot = consumer.collect();
     const dataPoints = snapshot[0].dataPoints;
 
@@ -220,5 +220,5 @@ function extractTraceContext(attributes) {
 
     consumer.close();
     metric.close();
-  });
+  }));
 }

test/parallel/test-metrics-observable-exception.js

@@ -52,7 +52,7 @@ throwOnCall = false;
 normalValue = 200;
 
 // Give nextTick a chance to fire the uncaughtException
-setImmediate(() => {
+setImmediate(common.mustCall(() => {
   // Second collect - both should work now
   const result2 = consumer.collect();
   assert.strictEqual(result2.length, 2);
@@ -64,4 +64,4 @@ setImmediate(() => {
   assert.strictEqual(normalMetric.dataPoints[0].value, 200);
 
   consumer.close();
-});
+}));