fs: fix glob lint issues

Author: mcollina

doc/api/fs.md

@@ -1350,7 +1350,7 @@ behavior is similar to `cp dir1/ dir2/`.
 added: v22.0.0
 changes:
   - version: REPLACEME
-    pr-url: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/62695
     description: Add support for the `followSymlinks` option.
   - version:
       - v24.1.0
@@ -3471,7 +3471,7 @@ descriptor. See [`fs.utimes()`][].
 added: v22.0.0
 changes:
   - version: REPLACEME
-    pr-url: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/62695
     description: Add support for the `followSymlinks` option.
   - version:
       - v24.1.0
@@ -6048,7 +6048,7 @@ Synchronous version of [`fs.futimes()`][]. Returns `undefined`.
 added: v22.0.0
 changes:
   - version: REPLACEME
-    pr-url: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/62695
     description: Add support for the `followSymlinks` option.
   - version:
       - v24.1.0

lib/internal/fs/glob.js

@@ -785,7 +785,9 @@ class Glob {
       const entryFullpath = join(fullpath, entry.name);
       this.#cache.addToStatCache(entryFullpath, entry);
       const entryIsDirectory = entry.isDirectory() ||
-        (this.#followSymlinks && entry.isSymbolicLink() && !!(await this.#cache.followStat(entryFullpath))?.isDirectory());
+        (this.#followSymlinks &&
+         entry.isSymbolicLink() &&
+         !!(await this.#cache.followStat(entryFullpath))?.isDirectory());
 
       const subPatterns = new SafeSet();
       const nSymlinks = new SafeSet();

test/parallel/test-fs-glob.mjs

@@ -551,8 +551,8 @@ const followSymlinkExpectedWithFollow = [
   'follow/link/file.txt'.replaceAll('/', sep),
 ].sort();
 
-const assertNoNestedCycleMatches = (matches) => {
-  assert.ok(!matches.some((match) => match.startsWith(`follow${sep}cycle${sep}`)), matches.join('\n'));
+const getNestedCycleMatches = (matches) => {
+  return matches.filter((match) => match.startsWith(`follow${sep}cycle${sep}`));
 };
 
 describe('glob - followSymlinks', function() {
@@ -569,7 +569,7 @@ describe('glob - followSymlinks', function() {
       followSymlinks: true,
     })).sort();
     assert.deepStrictEqual(actual, followSymlinkExpectedWithFollow);
-    assertNoNestedCycleMatches(actual);
+    assert.deepStrictEqual(getNestedCycleMatches(actual), []);
   });
 });
 
@@ -596,7 +596,7 @@ describe('globSync - followSymlinks', function() {
       followSymlinks: true,
     }).sort();
     assert.deepStrictEqual(actual, followSymlinkExpectedWithFollow);
-    assertNoNestedCycleMatches(actual);
+    assert.deepStrictEqual(getNestedCycleMatches(actual), []);
   });
 
   test('supports withFileTypes when following symlinked directories', () => {
@@ -608,7 +608,7 @@ describe('globSync - followSymlinks', function() {
     assertDirents(actual);
     const normalized = actual.map(normalizeDirent).sort();
     assert.deepStrictEqual(normalized, followSymlinkExpectedWithFollow);
-    assertNoNestedCycleMatches(normalized);
+    assert.deepStrictEqual(getNestedCycleMatches(normalized), []);
   });
 });
 
@@ -628,7 +628,7 @@ describe('fsPromises glob - followSymlinks', function() {
     })) actual.push(item);
     actual.sort();
     assert.deepStrictEqual(actual, followSymlinkExpectedWithFollow);
-    assertNoNestedCycleMatches(actual);
+    assert.deepStrictEqual(getNestedCycleMatches(actual), []);
   });
 });