fixup

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

Author: ShogunPanda

configure.py

@@ -797,9 +797,9 @@
     default=None,
     help='Enable the --trace-maps flag in V8 (use at your own risk)')
 
-parser.add_argument('--experimental',
+parser.add_argument('--enable-all-experimentals',
     action='store_true',
-    dest='experimental',
+    dest='enable_all_experimentals',
     default=None,
     help='Enable all experimental features by default')
 
@@ -1809,7 +1809,7 @@ def configure_node_cctest_sources(o):
 def configure_node(o):
   if options.dest_os == 'android':
     o['variables']['OS'] = 'android'
-  o['variables']['node_enable_experimentals'] = B(options.experimental)
+  o['variables']['node_enable_experimentals'] = B(options.enable_all_experimentals)
   o['variables']['node_prefix'] = options.prefix
   o['variables']['node_install_npm'] = b(not options.without_npm)
   o['variables']['node_install_corepack'] = b(options.with_corepack)

src/node_options.h

@@ -113,9 +113,9 @@ class DebugOptions : public Options {
 };
 
 #ifdef NODE_ENABLE_EXPERIMENTALS
-#define EXPERIMENTAL_OPTION(name, default_value) bool name = true;
+#define EXPERIMENTALS_DEFAULT_VALUE true
 #else
-#define EXPERIMENTAL_OPTION(name, default_value) bool name = default_value;
+#define EXPERIMENTALS_DEFAULT_VALUE false
 #endif
 
 class EnvironmentOptions : public Options {
@@ -128,19 +128,19 @@ class EnvironmentOptions : public Options {
   bool require_module = true;
   std::string dns_result_order;
   bool enable_source_maps = false;
-  EXPERIMENTAL_OPTION(experimental_addon_modules, false)
-  EXPERIMENTAL_OPTION(experimental_eventsource, false)
-  EXPERIMENTAL_OPTION(experimental_fetch, true)
-  EXPERIMENTAL_OPTION(experimental_ffi, false)
-  EXPERIMENTAL_OPTION(experimental_websocket, true)
-  EXPERIMENTAL_OPTION(experimental_sqlite, true)
-  EXPERIMENTAL_OPTION(experimental_stream_iter, false)
+  bool experimental_addon_modules = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_eventsource = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_fetch = true;
+  bool experimental_ffi = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_websocket = true;
+  bool experimental_sqlite = true;
+  bool experimental_stream_iter = EXPERIMENTALS_DEFAULT_VALUE;
   bool webstorage = HAVE_SQLITE;
-  EXPERIMENTAL_OPTION(experimental_quic, false)
+  bool experimental_quic = EXPERIMENTALS_DEFAULT_VALUE;
   std::string localstorage_file;
-  EXPERIMENTAL_OPTION(experimental_global_navigator, true)
-  EXPERIMENTAL_OPTION(experimental_global_web_crypto, true)
-  EXPERIMENTAL_OPTION(experimental_import_meta_resolve, false)
+  bool experimental_global_navigator = true;
+  bool experimental_global_web_crypto = true;
+  bool experimental_import_meta_resolve = EXPERIMENTALS_DEFAULT_VALUE;
   std::string input_type;  // Value of --input-type
   bool entry_is_url = false;
   bool permission = false;
@@ -154,8 +154,8 @@ class EnvironmentOptions : public Options {
   bool allow_wasi = false;
   bool allow_ffi = false;
   bool allow_worker_threads = false;
-  EXPERIMENTAL_OPTION(experimental_repl_await, true)
-  EXPERIMENTAL_OPTION(experimental_vm_modules, false)
+  bool experimental_repl_await = true;
+  bool experimental_vm_modules = EXPERIMENTALS_DEFAULT_VALUE;
   bool async_context_frame = true;
   bool expose_internals = false;
   bool force_node_api_uncaught_exceptions_policy = false;
@@ -182,10 +182,11 @@ class EnvironmentOptions : public Options {
   uint64_t cpu_prof_interval = kDefaultCpuProfInterval;
   std::string cpu_prof_name;
   bool cpu_prof = false;
-  EXPERIMENTAL_OPTION(experimental_network_inspection, false)
-  EXPERIMENTAL_OPTION(experimental_worker_inspection, false)
-  EXPERIMENTAL_OPTION(experimental_storage_inspection, false)
-  EXPERIMENTAL_OPTION(experimental_inspector_network_resource, false)
+  bool experimental_network_inspection = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_worker_inspection = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_storage_inspection = EXPERIMENTALS_DEFAULT_VALUE;
+  bool experimental_inspector_network_resource =
+      EXPERIMENTALS_DEFAULT_VALUE;
   std::string heap_prof_dir;
   std::string heap_prof_name;
   static const uint64_t kDefaultHeapProfInterval = 512 * 1024;
@@ -279,7 +280,7 @@ class EnvironmentOptions : public Options {
   bool report_exclude_env = false;
   bool report_exclude_network = false;
   std::string experimental_config_file_path;
-  EXPERIMENTAL_OPTION(experimental_default_config_file, false)
+  bool experimental_default_config_file = EXPERIMENTALS_DEFAULT_VALUE;
 
   inline DebugOptions* get_debug_options() { return &debug_options_; }
   inline const DebugOptions& debug_options() const { return debug_options_; }