src: cache context lookup in vectored io loops

Author: mertcanaltin

src/env-inl.h

@@ -897,7 +897,7 @@ v8::Local<v8::Context> Environment::context() const {
   return principal_realm()->context();
 }
 
-Realm* Environment::principal_realm() const {
+PrincipalRealm* Environment::principal_realm() const {
   return principal_realm_.get();
 }
 

src/env.h

@@ -886,7 +886,7 @@ class Environment final : public MemoryRetainer {
   // Get the context with an explicit realm instead when possible.
   // Deprecate soon.
   inline v8::Local<v8::Context> context() const;
-  inline Realm* principal_realm() const;
+  inline PrincipalRealm* principal_realm() const;
 
 #if HAVE_INSPECTOR
   inline inspector::Agent* inspector_agent() const {

src/node_file.cc

@@ -2391,10 +2391,9 @@ static void WriteBuffers(const FunctionCallbackInfo<Value>& args) {
 
   MaybeStackBuffer<uv_buf_t> iovs(chunks->Length());
 
-  Local<Context> context = env->context();
   for (uint32_t i = 0; i < iovs.length(); i++) {
     Local<Value> chunk;
-    if (!chunks->Get(context, i).ToLocal(&chunk)) return;
+    if (!chunks->Get(env->context(), i).ToLocal(&chunk)) return;
     CHECK(Buffer::HasInstance(chunk));
     iovs[i] = uv_buf_init(Buffer::Data(chunk), Buffer::Length(chunk));
   }
@@ -2777,10 +2776,9 @@ static void ReadBuffers(const FunctionCallbackInfo<Value>& args) {
   MaybeStackBuffer<uv_buf_t> iovs(buffers->Length());
 
   // Init uv buffers from ArrayBufferViews
-  Local<Context> context = env->context();
   for (uint32_t i = 0; i < iovs.length(); i++) {
     Local<Value> buffer;
-    if (!buffers->Get(context, i).ToLocal(&buffer)) return;
+    if (!buffers->Get(env->context(), i).ToLocal(&buffer)) return;
     CHECK(Buffer::HasInstance(buffer));
     iovs[i] = uv_buf_init(Buffer::Data(buffer), Buffer::Length(buffer));
   }

src/node_realm-inl.h

@@ -5,6 +5,7 @@
 
 #include "node_context_data.h"
 #include "node_realm.h"
+#include "util-inl.h"
 
 namespace node {
 
@@ -46,6 +47,10 @@ inline v8::Isolate* Realm::isolate() const {
   return isolate_;
 }
 
+inline v8::Local<v8::Context> Realm::context() const {
+  return PersistentToLocal::Strong(context_);
+}
+
 inline Realm::Kind Realm::kind() const {
   return kind_;
 }

src/node_realm.cc

@@ -295,10 +295,6 @@ void Realm::VerifyNoStrongBaseObjects() {
   });
 }
 
-v8::Local<v8::Context> Realm::context() const {
-  return PersistentToLocal::Strong(context_);
-}
-
 // Per-realm strong value accessors. The per-realm values should avoid being
 // accessed across realms.
 #define V(PropertyName, TypeName)                                              \

src/node_realm.h

@@ -121,7 +121,7 @@ class Realm : public MemoryRetainer {
   inline Environment* env() const;
   inline v8::Isolate* isolate() const;
   inline Kind kind() const;
-  virtual v8::Local<v8::Context> context() const;
+  inline virtual v8::Local<v8::Context> context() const;
   inline bool has_run_bootstrapping_code() const;
 
   // Methods created using SetMethod(), SetPrototypeMethod(), etc. inside