feat: make options an object

Author: efekrskl

lib/internal/fs/recursive_watch.js

@@ -51,7 +51,8 @@ class FSWatcher extends EventEmitter {
 
     assert(typeof options === 'object');
 
-    let { persistent, recursive, signal, encoding, ignore, throwIfNoEntry } = options;
+    const { persistent, recursive, signal, encoding, ignore } = options;
+    let { throwIfNoEntry } = options;
 
     // TODO(anonrig): Add non-recursive support to non-native-watcher for IBMi & AIX support.
     if (recursive != null) {
@@ -68,7 +69,7 @@ class FSWatcher extends EventEmitter {
 
     if (throwIfNoEntry != null) {
       validateBoolean(throwIfNoEntry, 'options.throwIfNoEntry');
-    }  else {
+    } else {
       throwIfNoEntry = true;
     }
 
@@ -228,7 +229,7 @@ class FSWatcher extends EventEmitter {
         this.#watchFolder(filename);
       }
     } catch (error) {
-      if (!this.#options.throwIfNoEntry && error.code === 'ENOENT') {
+      if (this.#options.throwIfNoEntry !== false && error.code === 'ENOENT') {
         error.filename = filename;
         throw error;
       }

lib/internal/main/watch_mode.js

@@ -104,7 +104,8 @@ function start() {
     ArrayPrototypeForEach(kEnvFiles, (file) => watcher.filterFile(resolve(file)));
   }
   if (kOptionalEnvFiles.length > 0) {
-    ArrayPrototypeForEach(kOptionalEnvFiles, (file) =>  watcher.filterFile(resolve(file), undefined, true));
+    ArrayPrototypeForEach(kOptionalEnvFiles,
+                          (file) => watcher.filterFile(resolve(file), undefined, { allowMissing: true }));
   }
   child.once('exit', (code) => {
     exited = true;

lib/internal/watch_mode/files_watcher.js

@@ -110,10 +110,12 @@ class FilesWatcher extends EventEmitter {
     return [...this.#watchers.keys()];
   }
 
-  watchPath(path, recursive = true, allowMissing = false) {
+  watchPath(path, recursive = true, options = kEmptyObject) {
     if (this.#isPathWatched(path)) {
       return;
     }
+    const { allowMissing = false } = options;
+
     const watcher = watch(path, { recursive, signal: this.#signal, throwIfNoEntry: !allowMissing });
     watcher.on('change', (eventType, fileName) => {
       // `fileName` can be `null` if it cannot be determined. See
@@ -126,14 +128,14 @@ class FilesWatcher extends EventEmitter {
     }
   }
 
-  filterFile(file, owner, allowMissing = false) {
+  filterFile(file, owner, options = kEmptyObject) {
     if (!file) return;
     if (supportsRecursiveWatching) {
-      this.watchPath(dirname(file),true, allowMissing);
+      this.watchPath(dirname(file), true, options);
     } else {
       // Having multiple FSWatcher's seems to be slower
       // than a single recursive FSWatcher
-      this.watchPath(file, false, allowMissing);
+      this.watchPath(file, false, options);
     }
     this.#filteredFiles.add(file);
     if (owner) {