src: validate node.config.json with JSON Schema

Author: mertcanaltin

src/node_config_file.cc

@@ -1,5 +1,7 @@
 #include "node_config_file.h"
+#include "ata.h"
 #include "debug_utils-inl.h"
+#include "node_config_schema.h"
 #include "simdjson.h"
 
 #include <string>
@@ -323,6 +325,32 @@ ParseResult ConfigReader::ParseConfig(const std::string_view& config_path) {
     }
   }
 
+  // Validate against JSON Schema. Skip additionalProperties errors
+  // because unknown namespaces are intentionally ignored.
+  {
+    auto schema = ata::compile(kNodeConfigSchema);
+    if (schema) {
+      auto result = ata::validate(schema, file_content);
+      if (!result.valid) {
+        for (const auto& err : result.errors) {
+          if (err.code != ata::error_code::additional_property_not_allowed) {
+            FPrintF(
+                stderr, "Invalid configuration in %s:\n", config_path.data());
+            for (const auto& e : result.errors) {
+              if (e.code != ata::error_code::additional_property_not_allowed) {
+                FPrintF(stderr,
+                        "  %s: %s\n",
+                        e.path.empty() ? "/" : e.path,
+                        e.message);
+              }
+            }
+            return ParseResult::InvalidContent;
+          }
+        }
+      }
+    }
+  }
+
   return ParseResult::Valid;
 }
 

src/node_metadata.cc

@@ -3,6 +3,7 @@
 #include "ada.h"
 #include "amaro_version.h"
 #include "ares.h"
+#include "ata.h"
 #include "brotli/encode.h"
 #include "llhttp.h"
 #include "merve.h"
@@ -171,6 +172,7 @@ Metadata::Versions::Versions() {
 #endif  // HAVE_SQLITE
   ada = ADA_VERSION;
   nbytes = NBYTES_VERSION;
+  ata = ATA_VERSION;
 }
 
 std::array<std::pair<std::string_view, std::string_view>,

src/node_metadata.h

@@ -64,7 +64,8 @@ namespace node {
   V(nghttp3)                                                                   \
   NODE_VERSIONS_KEY_AMARO(V)                                                   \
   NODE_VERSIONS_KEY_UNDICI(V)                                                  \
-  V(merve)
+  V(merve)                                                                     \
+  V(ata)
 
 #if HAVE_OPENSSL
 #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl) V(ncrypto)