module: add more test cases

Author: meixg

test/es-module/test-esm-dynamic-import-not-found-error-location.mjs

@@ -9,13 +9,13 @@ tmpdir.refresh();
 
 const missingPackage = 'this-package-does-not-exist';
 
-async function assertDynamicImportNotFoundLocation(entry, sourceLine, underline) {
+async function assertDynamicImportNotFoundLocation(entry, sourceLine, underline, line = 2) {
   const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [entry]);
 
   assert.strictEqual(code, 1);
   assert.strictEqual(signal, null);
   assert.strictEqual(stdout, '');
-  assert.ok(stderr.includes(`${entry}:2`));
+  assert.ok(stderr.includes(`${entry}:${line}`));
   assert.match(stderr, new RegExp(sourceLine));
   assert.match(stderr, underline);
   assert.match(stderr, /ERR_MODULE_NOT_FOUND/);
@@ -46,3 +46,29 @@ await assertDynamicImportNotFoundLocation(
   `import\\(${JSON.stringify(missingPackage)}\\);`,
   / {8}\^{27}/,
 );
+
+const variableEntry = tmpdir.resolve('dynamic-variable-entry.mjs');
+await writeFile(variableEntry, [
+  'Error.stackTraceLimit = 200;',
+  `const pkg = ${JSON.stringify(missingPackage)};`,
+  'await import(pkg);',
+].join('\n'));
+
+await assertDynamicImportNotFoundLocation(
+  variableEntry,
+  'await import\\(pkg\\);',
+  / {13}\^{27}/,
+  3,
+);
+
+const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
+  '--input-type=module',
+  '--eval',
+  `await import(${JSON.stringify(missingPackage)})`,
+]);
+
+assert.strictEqual(code, 1);
+assert.strictEqual(signal, null);
+assert.strictEqual(stdout, '');
+assert.match(stderr, /ERR_MODULE_NOT_FOUND/);
+assert.doesNotMatch(stderr, /await import/);

test/es-module/test-esm-module-not-found-error-location.mjs

@@ -14,12 +14,26 @@ await writeFile(entry, [
   'console.log(ok, missing);',
 ].join('\n'));
 
-const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [entry]);
+async function assertModuleNotFoundLocation(args) {
+  const { code, signal, stdout, stderr } = await spawnPromisified(execPath, args);
 
-assert.strictEqual(code, 1);
-assert.strictEqual(signal, null);
-assert.strictEqual(stdout, '');
-assert.ok(stderr.includes(`${entry}:2`));
-assert.match(stderr, /import missing from "this-package-does-not-exist";/);
-assert.match(stderr, / {21}\^{27}/);
-assert.match(stderr, /ERR_MODULE_NOT_FOUND/);
+  assert.strictEqual(code, 1);
+  assert.strictEqual(signal, null);
+  assert.strictEqual(stdout, '');
+  assert.ok(stderr.includes(`${entry}:2`));
+  assert.match(stderr, /import missing from "this-package-does-not-exist";/);
+  assert.match(stderr, / {21}\^{27}/);
+  assert.match(stderr, /ERR_MODULE_NOT_FOUND/);
+}
+
+await assertModuleNotFoundLocation([entry]);
+
+await assertModuleNotFoundLocation([
+  '--no-warnings',
+  '--import',
+  'data:text/javascript,' +
+    'import{register}from"node:module";' +
+    'register("data:text/javascript,' +
+    'export async function resolve(s,c,n){return n(s,c)}")',
+  entry,
+]);

test/parallel/test-internal-errors-error-source.js

@@ -0,0 +1,26 @@
+// Flags: --expose-internals
+'use strict';
+
+require('../common');
+
+const assert = require('assert');
+const { getErrorSourceMessage } = require('internal/errors/error_source');
+
+assert.strictEqual(
+  getErrorSourceMessage('file.js', 1, undefined, 0, 1),
+  undefined,
+);
+assert.strictEqual(
+  getErrorSourceMessage('file.js', Number.NaN, 'const value = 1;', 0, 1),
+  undefined,
+);
+
+assert.strictEqual(
+  getErrorSourceMessage('file.js', 1, '\tconst value = 1;', -5, 0),
+  'file.js:1\n\tconst value = 1;\n^\n',
+);
+
+assert.strictEqual(
+  getErrorSourceMessage('file.js', 7, `${'x'.repeat(20)}target${'y'.repeat(140)}`, 20, 200),
+  `file.js:7\n${'x'.repeat(20)}target${'y'.repeat(94)}...\n${' '.repeat(20)}${'^'.repeat(100)}\n`,
+);

test/parallel/test-module-not-found-error-location.js

@@ -45,3 +45,21 @@ assert.ok(longLineResult.stderr.includes(`${longLineEntry}:1`));
 assert.match(longLineResult.stderr, /\.\.\.x+"; require\("this-package-does-not-exist"\);/);
 assert.match(longLineResult.stderr, / {43}\^{27}/);
 assert.match(longLineResult.stderr, /MODULE_NOT_FOUND/);
+
+const variableEntry = tmpdir.resolve('variable-entry.cjs');
+writeFileSync(variableEntry, [
+  'const pkg = "this-package-does-not-exist";',
+  'require(pkg);',
+].join('\n'));
+
+const variableResult = spawnSync(process.execPath, [variableEntry], {
+  encoding: 'utf8',
+});
+
+assert.strictEqual(variableResult.status, 1);
+assert.strictEqual(variableResult.signal, null);
+assert.strictEqual(variableResult.stdout, '');
+assert.ok(variableResult.stderr.includes(`${variableEntry}:2`));
+assert.match(variableResult.stderr, /require\(pkg\);/);
+assert.match(variableResult.stderr, /^\^{27}$/m);
+assert.match(variableResult.stderr, /MODULE_NOT_FOUND/);