Merge branch 'main' into fix-static-analysis-warnings

Author: GoldFish2500

.configurations/configuration.dsc.yaml

@@ -5,11 +5,11 @@ properties:
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: pythonPackage
       directives:
-        description: Install Python 3.12
+        description: Install Python 3.14
         module: Microsoft.WinGet.DSC
         allowPrerelease: true
       settings:
-        id: Python.Python.3.12
+        id: Python.Python.3.14
         source: winget
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: vsPackage
@@ -51,4 +51,4 @@ properties:
       settings:
         id: Nasm.Nasm
         source: winget
-  configurationVersion: 0.1.0
+  configurationVersion: 0.1.1

.configurations/configuration.vsBuildTools.dsc.yaml

@@ -0,0 +1,54 @@
+# yaml-language-server: $schema=https://aka.ms/configuration-dsc-schema/0.2
+# Reference: https://github.com/nodejs/node/blob/main/BUILDING.md#windows
+properties:
+  resources:
+    - resource: Microsoft.WinGet.DSC/WinGetPackage
+      id: pythonPackage
+      directives:
+        description: Install Python 3.14
+        module: Microsoft.WinGet.DSC
+        allowPrerelease: true
+      settings:
+        id: Python.Python.3.14
+        source: winget
+    - resource: Microsoft.WinGet.DSC/WinGetPackage
+      id: vsPackage
+      directives:
+        description: Install Visual Studio 2022 Build Tools
+        allowPrerelease: true
+      settings:
+        id: Microsoft.VisualStudio.2022.BuildTools
+        source: winget
+        useLatest: true
+    - resource: Microsoft.VisualStudio.DSC/VSComponents
+      id: vsComponents
+      dependsOn:
+        - vsPackage
+      directives:
+        description: Install required VS workloads and components
+        allowPrerelease: true
+      settings:
+        productId: Microsoft.VisualStudio.Product.BuildTools
+        channelId: VisualStudio.17.Release
+        includeRecommended: true
+        components:
+          - Microsoft.VisualStudio.Workload.VCTools
+          - Microsoft.VisualStudio.Component.VC.Llvm.Clang
+          - Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset
+    - resource: Microsoft.WinGet.DSC/WinGetPackage
+      id: gitPackage
+      directives:
+        description: Install Git
+        allowPrerelease: true
+      settings:
+        id: Git.Git
+        source: winget
+    - resource: Microsoft.WinGet.DSC/WinGetPackage
+      id: nasmPackage
+      directives:
+        description: Install NetWide Assembler (NASM)
+        allowPrerelease: true
+      settings:
+        id: Nasm.Nasm
+        source: winget
+  configurationVersion: 0.1.1

.configurations/configuration.vsEnterprise.dsc.yaml

@@ -5,11 +5,11 @@ properties:
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: pythonPackage
       directives:
-        description: Install Python 3.12
+        description: Install Python 3.14
         module: Microsoft.WinGet.DSC
         allowPrerelease: true
       settings:
-        id: Python.Python.3.12
+        id: Python.Python.3.14
         source: winget
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: vsPackage
@@ -51,4 +51,4 @@ properties:
       settings:
         id: Nasm.Nasm
         source: winget
-  configurationVersion: 0.1.0
+  configurationVersion: 0.1.1

.configurations/configuration.vsProfessional.dsc.yaml

@@ -5,11 +5,11 @@ properties:
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: pythonPackage
       directives:
-        description: Install Python 3.12
+        description: Install Python 3.14
         module: Microsoft.WinGet.DSC
         allowPrerelease: true
       settings:
-        id: Python.Python.3.12
+        id: Python.Python.3.14
         source: winget
     - resource: Microsoft.WinGet.DSC/WinGetPackage
       id: vsPackage
@@ -51,4 +51,4 @@ properties:
       settings:
         id: Nasm.Nasm
         source: winget
-  configurationVersion: 0.1.0
+  configurationVersion: 0.1.1

.devcontainer/base/devcontainer.json

@@ -7,5 +7,6 @@
   "mounts": [
     "source=node-devcontainer-cache,target=/home/developer/nodejs/node/out,type=volume"
   ],
-  "postCreateCommand": "git restore-mtime"
+  "postCreateCommand": "git restore-mtime",
+  "postStartCommand": "cp /home/developer/envrc/static-libs.envrc /home/developer/nodejs/node/.envrc && direnv allow /home/developer/nodejs/node"
 }

.github/CODEOWNERS

@@ -23,13 +23,10 @@
 /onboarding.md @nodejs/tsc
 
 # nodejs.org website
-/doc/api_assets @nodejs/nodejs-website
-/doc/template.html @nodejs/nodejs-website
 /tools/doc @nodejs/web-infra
 
 # streams
 
-/lib/_stream* @nodejs/streams
 /lib/internal/streams/* @nodejs/streams
 /lib/stream.js @nodejs/streams
 /lib/stream/* @nodejs/streams
@@ -153,13 +150,15 @@
 /test/parallel/test-runner-* @nodejs/test_runner
 
 # Single Executable Applications
+/deps/LIEF @nodejs/single-executable
 /deps/postject @nodejs/single-executable
 /doc/api/single-executable-applications.md @nodejs/single-executable
 /doc/contributing/maintaining/maintaining-single-executable-application-support.md @nodejs/single-executable
 /src/node_sea* @nodejs/single-executable
 /test/fixtures/postject-copy @nodejs/single-executable
 /test/sea @nodejs/single-executable
 /tools/dep_updaters/update-postject.sh @nodejs/single-executable
+/tools/dep_updaters/update-lief.sh @nodejs/single-executable
 
 # Permission Model
 /doc/api/permissions.md @nodejs/security-wg

.github/ISSUE_TEMPLATE/config.yml

@@ -5,10 +5,10 @@ contact_links:
     about: Please file an issue in our help repo.
   - name: 📦 Have an issue with npm?
     url: https://github.com/npm/cli/issues
-    about: npm has a seperate issue tracker.
+    about: npm has a separate issue tracker.
   - name: 📡 Have an issue with undici? (`WebSocket`, `fetch`, etc.)
     url: https://github.com/nodejs/undici/issues
-    about: Undici has a seperate issue tracker.
+    about: Undici has a separate issue tracker.
   - name: 🌐 Found a problem with nodejs.org beyond the API reference docs?
     url: https://github.com/nodejs/nodejs.org/issues/new/choose
     about: Please file an issue in the Node.js website repo.

.github/label-pr-config.yml

@@ -80,7 +80,7 @@ subSystemLabels:
   /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
   /^deps\/v8\//: v8 engine
   /^deps\/uvwasi\//: wasi
-  /^deps\/npm\//: npm, fast-track
+  /^deps\/npm\//: npm
   /^deps\/nghttp2\/nghttp2\.gyp/: build, http2
   /^deps\/nghttp2\//: http2
   /^deps\/ngtcp2\//: quic

.github/workflows/auto-start-ci.yml

@@ -21,20 +21,20 @@ jobs:
     permissions:
       pull-requests: read
     if: github.repository == 'nodejs/node'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim
     outputs:
       numbers: ${{ steps.get_prs_for_ci.outputs.numbers }}
     steps:
       - name: Get Pull Requests
         id: get_prs_for_ci
         run: >
-          numbers=$(gh pr list \
-                  --repo ${{ github.repository }} \
+          echo "numbers=$(gh pr list \
+                  --repo "$GITHUB_REPOSITORY" \
                   --label 'request-ci' \
                   --json 'number' \
+                  --search 'review:approved' \
                   -t '{{ range . }}{{ .number }} {{ end }}' \
-                  --limit 5)
-          echo "numbers=$numbers" >> $GITHUB_OUTPUT
+                  --limit 5)" >> "$GITHUB_OUTPUT"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   start-ci:
@@ -43,14 +43,10 @@ jobs:
       pull-requests: write
     needs: get-prs-for-ci
     if: needs.get-prs-for-ci.outputs.numbers != ''
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim
     steps:
-      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8  # v6.0.1
-        with:
-          persist-credentials: false
-
       - name: Install Node.js
-        uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f  # v6.1.0
+        uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f  # v6.3.0
         with:
           node-version: ${{ env.NODE_VERSION }}
 
@@ -62,14 +58,17 @@ jobs:
           ncu-config set username "$USERNAME"
           ncu-config set token "$GH_TOKEN"
           ncu-config set jenkins_token "$JENKINS_TOKEN"
-          ncu-config set owner "${{ github.repository_owner }}"
-          ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
+          ncu-config set owner "$GITHUB_REPOSITORY_OWNER"
+          ncu-config set repo "$(echo "$GITHUB_REPOSITORY" | cut -d/ -f2)"
         env:
           USERNAME: ${{ secrets.JENKINS_USER }}
           GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}
           JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }}
 
       - name: Start the CI
-        run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
+        run: |
+          curl -fsSL "https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/start-ci.sh" \
+          | sh -s -- ${{ needs.get-prs-for-ci.outputs.numbers }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_REPO: ${{ github.repository }}

.github/workflows/build-tarball.yml

@@ -18,7 +18,6 @@ on:
       - tsconfig.json
       - test/internet/**
       - tools/actions/**
-      - tools/bootstrap/**
       - tools/dep_updaters/**
       - tools/doc/**
       - tools/eslint-rules/**
@@ -48,7 +47,6 @@ on:
       - tsconfig.json
       - test/internet/**
       - tools/actions/**
-      - tools/bootstrap/**
       - tools/dep_updaters/**
       - tools/doc/**
       - tools/eslint-rules/**
@@ -74,13 +72,13 @@ permissions:
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-slim
     steps:
-      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8  # v6.0.1
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548  # v6.1.0
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405  # v6.2.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
           allow-prereleases: true
@@ -93,20 +91,21 @@ jobs:
           export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
           ./configure && make tar -j4 SKIP_XZ=1
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f  # v6.0.0
+        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f  # v7.0.0
         with:
           name: tarballs
           path: '*.tar.gz'
           compression-level: 0
   test-tarball-linux:
     needs: build-tarball
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-24.04-arm
     env:
-      CC: sccache clang-19
-      CXX: sccache clang++-19
-      SCCACHE_GHA_ENABLED: 'true'
+      CC: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang-19
+      CXX: ${{ (github.base_ref == 'main' || github.ref_name == 'main') && 'sccache' || '' }} clang++-19
+      SCCACHE_GHA_ENABLED: ${{ github.base_ref == 'main' || github.ref_name == 'main' }}
+      SCCACHE_IDLE_TIMEOUT: '0'
     steps:
-      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8  # v6.0.1
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         with:
           persist-credentials: false
           sparse-checkout: .github/actions/install-clang
@@ -116,18 +115,19 @@ jobs:
         with:
           clang-version: ${{ env.CLANG_VERSION }}
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548  # v6.1.0
+        uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405  # v6.2.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
           allow-prereleases: true
       - name: Set up sccache
+        if: github.base_ref == 'main' || github.ref_name == 'main'
         uses: Mozilla-Actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # v0.0.9
         with:
           version: v0.12.0
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131  # v7.0.0
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
         with:
           name: tarballs
           path: tarballs