Skip to content

Commit 5a69e55

Browse files
committed
fix: fix aix build
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
1 parent 119c50d commit 5a69e55

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

Makefile

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -552,21 +552,18 @@ FFI_BINDING_SOURCES := \
552552
$(wildcard test/ffi/*/*.def)
553553

554554
ifndef NOFFI
555-
# Implicitly depends on $(NODE_EXE), see the build-ffi-tests rule for rationale.
555+
# Depends on $(NODE_EXE) as order-only to avoid ETXTBSY on AIX when make
556+
# tries to execute node while it is still being linked in parallel.
556557
test/ffi/.buildstamp: $(ADDONS_PREREQS) \
557-
$(FFI_BINDING_GYPS) $(FFI_BINDING_SOURCES)
558+
$(FFI_BINDING_GYPS) $(FFI_BINDING_SOURCES) | $(NODE_EXE)
558559
@$(call run_build_addons,"$$PWD/test/ffi",$@)
559560
else
560561
test/ffi/.buildstamp:
561562
endif
562563

563564
.PHONY: build-ffi-tests
564565
ifndef NOFFI
565-
# .buildstamp needs $(NODE_EXE) but cannot depend on it
566-
# directly because it calls make recursively. The parent make cannot know
567-
# if the subprocess touched anything so it pessimistically assumes that
568-
# .buildstamp is out of date and need a rebuild.
569-
build-ffi-tests: | $(NODE_EXE) test/ffi/.buildstamp ## Build FFI tests.
566+
build-ffi-tests: | test/ffi/.buildstamp ## Build FFI tests.
570567
else
571568
build-ffi-tests:
572569
endif

0 commit comments

Comments
 (0)