src: unguard the experimental_quic_ option field

When configured to build `--without_ssl`, having the
experimental_quic_ option field guarded was causing an
ODR violation in the 'node_options.h` header causing
a misalignment in the struct depending on the number
of bool fields defined. There's no need to guard the
field, only the registration of the option itself.

Author: jasnell

src/node_options.h

@@ -129,9 +129,7 @@ class EnvironmentOptions : public Options {
   bool experimental_sqlite = true;
   bool experimental_stream_iter = false;
   bool webstorage = HAVE_SQLITE;
-#ifndef OPENSSL_NO_QUIC
   bool experimental_quic = false;
-#endif
   std::string localstorage_file;
   bool experimental_global_navigator = true;
   bool experimental_global_web_crypto = true;
@@ -287,7 +285,7 @@ class PerIsolateOptions : public Options {
   PerIsolateOptions() = default;
   PerIsolateOptions(PerIsolateOptions&&) = default;
 
-  std::shared_ptr<EnvironmentOptions> per_env { new EnvironmentOptions() };
+  std::shared_ptr<EnvironmentOptions> per_env{new EnvironmentOptions()};
   bool track_heap_objects = false;
   bool report_uncaught_exception = false;
   bool report_on_signal = false;
@@ -320,7 +318,7 @@ class PerProcessOptions : public Options {
   // using the node::per_process::cli_options_mutex, typically:
   //
   //     Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
-  std::shared_ptr<PerIsolateOptions> per_isolate { new PerIsolateOptions() };
+  std::shared_ptr<PerIsolateOptions> per_isolate{new PerIsolateOptions()};
 
   std::string title;
   std::string trace_event_categories;
@@ -474,38 +472,38 @@ class OptionsParser {
   void AddOption(
       const char* name,
       const char* help_text,
-      bool Options::*field,
+      bool Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       bool default_is_true = false,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
       const char* name,
       const char* help_text,
-      uint64_t Options::*field,
+      uint64_t Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
       const char* name,
       const char* help_text,
-      int64_t Options::*field,
+      int64_t Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
       const char* name,
       const char* help_text,
-      std::string Options::*field,
+      std::string Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
       const char* name,
       const char* help_text,
-      std::vector<std::string> Options::*field,
+      std::vector<std::string> Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
       const char* name,
       const char* help_text,
-      HostPort Options::*field,
+      HostPort Options::* field,
       OptionEnvvarSettings env_setting = kDisallowedInEnvvar,
       OptionNamespaces namespace_id = OptionNamespaces::kNoNamespace);
   void AddOption(
@@ -530,8 +528,7 @@ class OptionsParser {
   // if the option has a non-option argument (not starting with -) following it.
   void AddAlias(const char* from, const char* to);
   void AddAlias(const char* from, const std::vector<std::string>& to);
-  void AddAlias(const char* from,
-                const std::initializer_list<std::string>& to);
+  void AddAlias(const char* from, const std::initializer_list<std::string>& to);
 
   // Add implications from some arbitrary option to a boolean one, either
   // in a way that makes `from` set `to` to true or to false.
@@ -543,7 +540,7 @@ class OptionsParser {
   // type.
   template <typename ChildOptions>
   void Insert(const OptionsParser<ChildOptions>& child_options_parser,
-              ChildOptions* (Options::* get_child)());
+              ChildOptions* (Options::*get_child)());
 
   // Parse a sequence of options into an options struct, a list of
   // arguments that were parsed as options, a list of unknown/JS engine options,
@@ -632,17 +629,15 @@ class OptionsParser {
   // These are helpers that make `Insert()` support properties of other
   // options structs, if we know how to access them.
   template <typename OriginalField, typename ChildOptions>
-  static auto Convert(
-      std::shared_ptr<OriginalField> original,
-      ChildOptions* (Options::* get_child)());
+  static auto Convert(std::shared_ptr<OriginalField> original,
+                      ChildOptions* (Options::*get_child)());
   template <typename ChildOptions>
-  static auto Convert(
-      typename OptionsParser<ChildOptions>::OptionInfo original,
-      ChildOptions* (Options::* get_child)());
+  static auto Convert(typename OptionsParser<ChildOptions>::OptionInfo original,
+                      ChildOptions* (Options::*get_child)());
   template <typename ChildOptions>
   static auto Convert(
       typename OptionsParser<ChildOptions>::Implication original,
-      ChildOptions* (Options::* get_child)());
+      ChildOptions* (Options::*get_child)());
 
   std::unordered_map<std::string, OptionInfo> options_;
   std::unordered_map<std::string, std::vector<std::string>> aliases_;
@@ -669,10 +664,12 @@ class OptionsParser {
 
 using StringVector = std::vector<std::string>;
 template <class OptionsType, class = Options>
-void Parse(
-  StringVector* const args, StringVector* const exec_args,
-  StringVector* const v8_args, OptionsType* const options,
-  OptionEnvvarSettings required_env_settings, StringVector* const errors);
+void Parse(StringVector* const args,
+           StringVector* const exec_args,
+           StringVector* const v8_args,
+           OptionsType* const options,
+           OptionEnvvarSettings required_env_settings,
+           StringVector* const errors);
 
 }  // namespace options_parser