build: fix ata build for shared library configurations

Author: mertcanaltin

deps/ata/ata.gyp

@@ -12,16 +12,12 @@
       'direct_dependent_settings': {
         'include_dirs': ['.'],
       },
-      'dependencies': [
-        '../simdjson/simdjson.gyp:simdjson',
-      ],
-      'defines': [
-        'ATA_NO_RE2',
-      ],
-      'sources': [
-        '<@(ata_sources)',
-      ],
       'conditions': [
+        ['node_shared_simdjson=="false"', {
+          'dependencies': [
+            '../simdjson/simdjson.gyp:simdjson',
+          ],
+        }],
         ['OS=="win"', {
           'msvs_settings': {
             'VCCLCompilerTool': {
@@ -35,6 +31,12 @@
           },
         }],
       ],
+      'defines': [
+        'ATA_NO_RE2',
+      ],
+      'sources': [
+        '<@(ata_sources)',
+      ],
     },
   ]
 }

node.gypi

@@ -237,7 +237,10 @@
         'dependencies': [ 'deps/simdjson/simdjson.gyp:simdjson' ],
     }],
 
-    [ 'node_shared_simdjson=="false"', {
+    # ata is always built from source (no shared library option).
+    # When simdjson is shared, ata still links against the shared lib
+    # through its own simdjson dependency in ata.gyp.
+    ['1==1', {
         'dependencies': [ 'deps/ata/ata.gyp:ata' ],
     }],